Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add demo gif #9

Merged
merged 2 commits into from
Jun 16, 2021
Merged

Add demo gif #9

merged 2 commits into from
Jun 16, 2021

Conversation

shubydo
Copy link
Collaborator

@shubydo shubydo commented Jun 16, 2021

Proposed changes

Add demo gif to README

Other changes:

  • Set version of go in build workflow. Not setting the version was causing errors: example

Issues for these changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (changes to code, which do not change application behavior)

Checklist

  • I have filled out this PR template
  • I have read the CONTRIBUTING doc
  • I have added automated tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (README.md, CHANGELOG.md, etc. - if appropriate)

Dependencies and Blockers

Relevant Links

Further comments

@shubydo shubydo requested a review from bjfish25 June 16, 2021 13:24
@shubydo shubydo self-assigned this Jun 16, 2021
@shubydo shubydo requested a review from rajholla June 16, 2021 13:25
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Copy link

@bryonwinger bryonwinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition!

@shubydo shubydo merged commit 5922523 into master Jun 16, 2021
@shubydo shubydo deleted the add-demo-gif branch June 16, 2021 17:03
@github-actions
Copy link

Unit Test Results

    2 files  ±0      2 suites  ±0   10s ⏱️ ±0s
249 tests ±0  249 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 5922523. ± Comparison against base commit d9c5b21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants