Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: runiac_container build arg should only be added to docker bui… #28

Merged
merged 1 commit into from
May 14, 2021

Conversation

tiny-dancer
Copy link
Contributor

@tiny-dancer tiny-dancer commented May 14, 2021

bugfix: runiac_container build arg should only be added to docker build when value exists

Proposed changes

Issues for these changes

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (changes to code, which do not change application behavior)

Checklist

  • I have filled out this PR template
  • I have read the CONTRIBUTING doc
  • I have added automated tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (README.md, CHANGELOG.md, etc. - if appropriate)

Dependencies and Blockers

Relevant Links

Further comments

@github-actions

This comment has been minimized.

@tiny-dancer tiny-dancer merged commit 5065792 into main May 14, 2021
@tiny-dancer tiny-dancer deleted the bugfix/runiac-container-build-arg branch May 14, 2021 19:40
@github-actions
Copy link

Unit Test Results

  1 files  ±0  13 suites  ±0   0s ⏱️ ±0s
48 tests +1  48 ✔️ +1  0 💤 ±0  0 ❌ ±0 

Results for commit 5065792. ± Comparison against base commit d2bdc65.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant