Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove and upload capabilities nodejs #74

Merged
merged 10 commits into from Nov 15, 2017

Conversation

abaliunov-sc
Copy link
Contributor

@abaliunov-sc abaliunov-sc commented Nov 14, 2017

@abaliunov-sc abaliunov-sc changed the title Remove capability nodejs/#18 Remove and upload capabilities nodejs Nov 14, 2017
@@ -0,0 +1,2 @@
.set-name-dialog {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this CSS class

};

export default
class CancelOkDialog extends Component {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename CancelOkDialog to ConfirmDialog

</div>

<div className="oc-fm--dialog__horizontal-group oc-fm--dialog__horizontal-group--to-right">
<button type="button" className="oc-fm--dialog__button oc-fm--dialog__button--default" onClick={onHide}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please create handleCancel method as handleSubmit done

Copy link
Contributor

@kvolkovich-sc kvolkovich-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make requested changes.

There are several code-style errors, but eslint is still not enabled on CircleCI, so its not a problem for now. =)

};
const defaultProps = {
headerText: 'Do you really want to remove the file?',
submitButtonText: 'Ok',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make Ok uppercase

api.removeResources(apiOptions, selectedResources, { onSuccess, onFail });
}}
headerText={`Do you really want to remove\n${selectedResources.length > 1 ? `${selectedResources.length} files` : `the file ${selectedResources[0].name}`}?`}
submitButtonText={'Ok'}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make Ok uppercase

@abaliunov-sc
Copy link
Contributor Author

Done

Copy link
Contributor

@kvolkovich-sc kvolkovich-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now looks OK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants