Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/10 #18

Closed
wants to merge 45 commits into from
Closed

Enhancement/10 #18

wants to merge 45 commits into from

Conversation

abaliunov-sc
Copy link
Contributor

Fixed error "Rich Editor does not show cursor on UI in empty lines"

@kvolkovich-sc
Copy link
Contributor

kvolkovich-sc commented Jul 26, 2017

Bugs checklist for @abaliunov-sc :


  • How reproduce: scroll to code, mouse click to next line (not so easy), write some text and press Return.

bug1

Current behavior: line break added, but cursor not jumps to next line
Expected behavior: line break added and cursor jumps to next line


  • How reproduce: scroll to Indented code mouse click to end of code block,
    pressReturn.

bug2

Current behavior: new empty code block added
Expected behavior: old code block should increase in size


  • How reproduce: scroll to Lists mouse click to end of one of first-level list item,
    press Return.

bug3

Current behavior: new child list item added with two bullets
Expected behavior: new child list item added with one bullet


  • How reproduce: scroll to Definition lists mouse click to end of Term1 press Return, then press Return again.

bug4

Current behavior: new line added after second Return press
Expected behavior: definition list item added after first Return press

Copy link
Contributor

@kvolkovich-sc kvolkovich-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See bugs checklist above

@abaliunov-sc
Copy link
Contributor Author

abaliunov-sc commented Jul 26, 2017

First bug fixed.
Second and third bugs are not related to serializer. It seems like behavior of Slate Editor. Should be reviewed by @ddivin-sc

Copy link
Contributor

@asergeev-sc asergeev-sc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Rich' editor markdown editor is not ok.
As discussed orally files structure should be changes. Code that parses slate state to text (markdown) should be written as 2 'pure' functions 'serialize' and 'deserialize'.

@kvolkovich-sc
Copy link
Contributor

Bug

How reproduce: in "plain editor mode" type a link inside bold / italic / strikethrough. Switch to "rich editor mode", click to some text, switch back to "plain editor mode".

bug5

Current behavior: Bold / italic / strikethrough symbols disappeared.
Expected behavior: Nothing disappeared.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7368328 on enhancement/10 into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f65ee13 on enhancement/10 into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f92b633 on enhancement/10 into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7d0cb6a on enhancement/10 into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f5d16e0 on enhancement/10 into ** on master**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 52e63d4 on enhancement/10 into ** on master**.

@amourzenkov-sc amourzenkov-sc self-requested a review August 4, 2017 06:34
@asergeev-sc asergeev-sc removed the request for review from amourzenkov-sc August 4, 2017 07:01
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 2a93277 on enhancement/10 into ** on master**.

@asergeev-sc
Copy link
Contributor

The feature is not actual for the moment.

@asergeev-sc asergeev-sc deleted the enhancement/10 branch August 21, 2019 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants