Port Many prs v2 #222
Port Many prs v2 #222
Conversation
first batch
ports: tgstation/tgstation#31145 tgstation/tgstation#31165 tgstation/tgstation#31163 tgstation/tgstation#30297 tgstation/tgstation#29268 tgstation/tgstation#30633 tgstation/tgstation#31137 tgstation/tgstation#32162 tgstation/tgstation#30970 and yes it compiles. these should be all the prs i ported, may of forgot to list the minor hotfixes ones i had to do also did some other fixes for gangwars zlevel since we still have the game mode thankkfully
|
Shouldn't you just be pulling from /tg/ upstream at this point? I mean I don't know the contents of these PRs/ports but I could only imagine such |
SamHPurp
added
Fix
|
We're too different code wise for a bot to handle @taukausanake |
| M.dest = pickedgoal | ||
| M.z_original = ZLEVEL_STATION | ||
| spawn(0) | ||
| walk_towards(M, M.dest, 1) |
There was a problem hiding this comment.
Lines 43 and 44 shouldn't have been deleted here.
|
Good catch, @FlattestGuitar I think I'd prefer if these ports remain their own individual PRs (other than subsequent fixes, those can all be rolled into one) But if they're are entirely differnt, they should stay as separate PRs. |
|
Yeah, I've already talked to Scrub about their approach. Don't do this, kids. |
|
Also, that comment I made earlier was apparently not quite right, since it works fine because Scrub also ported another PR which he forgot to mention in the OP. |
ports:
tgstation/tgstation#31145
tgstation/tgstation#31165
tgstation/tgstation#31163
tgstation/tgstation#30297
tgstation/tgstation#29268
tgstation/tgstation#30633
tgstation/tgstation#31137
tgstation/tgstation#32162
tgstation/tgstation#30970
and yes it compiles.
these should be all the prs i ported, may of forgot to list the minor hotfixes ones i had to do
also did some other fixes for gangwars zlevel since we still have the game mode thankkfully