Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error importing a valid gimp palette file #502

Closed
Ryder17z opened this issue Jun 26, 2021 · 3 comments
Closed

error importing a valid gimp palette file #502

Ryder17z opened this issue Jun 26, 2021 · 3 comments
Labels
bug Something isn't working

Comments

@Ryder17z
Copy link

Pixelorama version:
0.8.3 (snap)

OS/device including version:
Manjaro Linux 21.0.7

Issue description:
image

it should correctly import this file of about 730 colors.
GIMP loads it without complaints:
image

Steps to reproduce:
Try to import this file into Pixelorama:
color_palette.pal.txt

@Ryder17z Ryder17z added the bug Something isn't working label Jun 26, 2021
@OverloadedOrama
Copy link
Member

This doesn't seem to be a valid .pal file. .pal palette files start with "JASC-PAL" as their first line (source: https://liero.nl/lierohack/docformats/other-jasc.html). This is actually a .gpl file. Changing the file extension from .pal to .gpl and then importing this to Pixelorama seems to be working fine. But if desired, we could add a way to detect an invalid .pal file and try to import it as a .gpl instead, so you wouldn't have to change the file's extension.

@Ryder17z
Copy link
Author

ooops. but yes. automatically determine format by file header would be nice.

@novhack
Copy link
Contributor

novhack commented Jul 29, 2021

I added the palette header detection to future enhancements of the palette system. It will be tracked here #356 so I guess this issue can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants