Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An empty 0B pxo file is saved if Pixelorama crashes during saving #763

Closed
OverloadedOrama opened this issue Oct 5, 2022 · 0 comments
Closed
Labels
bug Something isn't working

Comments

@OverloadedOrama
Copy link
Member

Pixelorama version:
v0.10.3 and v0.11-dev (latest master), most likely previous versions too.

OS/device including version:
OpenSUSE Tumbleweed, but it has been reported on Windows 10 Pro as well.

Issue description:
Related to #762, but I decided to keep these issues separate, as even if #762 is fixed, more situations causing crashes may linger. The issue is that, if Pixelorama crashes during saving, a 0B pxo file is being saved, which replaces the previous pxo file with the same file name on the same folder, if it exists. This is a serious issue because it can result to data loss.

An idea I had to solve the issue would be to check if a file with the same name exists, and if it does, save the pxo with a different file name. If that is saved successfully, we then rename it, replacing the previous pxo file.

Steps to reproduce:
You can follow #762's steps to reproduce to cause a crash.

@OverloadedOrama OverloadedOrama added bug Something isn't working help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant