Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump Storybook from 6.4.9 to 7.6.15 #151

Merged
merged 27 commits into from
Feb 15, 2024
Merged

chore(deps): bump Storybook from 6.4.9 to 7.6.15 #151

merged 27 commits into from
Feb 15, 2024

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Feb 6, 2024 •
edited

Description

This PR bumps Storybook from 6.4.9 to 7.6.15.
This looks simple but it hides some complicated stuff:

  • Migrating Node from v14 to v20
  • Configuring correctly Storybook in 7.6.15
  • Getting rid of the deprecated storybook/addon-knobs and replacing all the use cases by a more modern and regular use of stories

@julien-deramond julien-deramond added documentation dependencies Pull requests that update a dependency file chore labels Feb 6, 2024
@julien-deramond julien-deramond force-pushed the master-jd-bump-storybook-to-latest branch from 2d62bf4 to c53bcb3 Compare February 6, 2024 14:48
louismaximepiton
louismaximepiton approved these changes Feb 9, 2024
View reviewed changes
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be great, haven't seen regression (apart some form element issues), the behavior is the same as before. Well done!

@julien-deramond julien-deramond marked this pull request as ready for review February 15, 2024 11:42
@julien-deramond julien-deramond changed the title chore(deps): bump Storybook from 6.4.9 to 7.6.12 chore(deps): bump Storybook from 6.4.9 to 7.6.15 Feb 15, 2024
@julien-deramond julien-deramond merged commit 9c485fb into master Feb 15, 2024
@julien-deramond julien-deramond deleted the master-jd-bump-storybook-to-latest branch February 15, 2024 11:43
This was referenced Feb 15, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louismaximepiton louismaximepiton louismaximepiton approved these changes

Assignees
No one assigned
Labels
chore dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julien-deramond @louismaximepiton