This repository has been archived by the owner on Dec 13, 2023. It is now read-only.
Removing eventListeners after stop command #13
Comments
This was referenced Jul 19, 2018
Closed
Closed
Merged
sebdurand
added a commit
that referenced
this issue
Jul 19, 2018
* fix rollup export interface @see rollup/rollup-plugin-typescript#28 * fix attach/detach listeners after load/clear * fix return id tracks not implemented * fix attach/detach listeners after load/clear * fix return id tracks not implemented * Update package.json * Update package.json * add skip_cleanup: true / deploy / npm
sebdurand
added a commit
that referenced
this issue
Jul 19, 2018
* 1.0.3 (#3) * refactoring : playbackstatus as int * fix reply connection status * fix getMetadata * fix tracks * fix format code * 1.0.4 (#12) * refactoring : playbackstatus as int * fix reply connection status * fix getMetadata * fix tracks * fix format code * Fix playback status, connection status, metadata and tracks support. * refactoring : playbackstatus as int * fix reply connection status * fix getMetadata * fix tracks * fix format code * fix npmjs deploy * fix npm deploy * fixes #6 #7 #8 #9 #13 (#18) * fix rollup export interface @see rollup/rollup-plugin-typescript#28 * fix attach/detach listeners after load/clear * fix return id tracks not implemented * fix attach/detach listeners after load/clear * fix return id tracks not implemented * add skip_cleanup: true / deploy / npm * update protocol * fix handle propertly transmission errors
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The eventListeners are registered to mediaElement in the constructor of Media object and are removed after stop command is processed. They are never registered again. This makes it impossible to cast one stream, stop it and cast another one while getting playbackStatus info without re-initiating the whole VideoMediaManager.
Could you please add the event listeners again in prepare command processing or simply not remove them.
Thank you.
The text was updated successfully, but these errors were encountered: