Skip to content
This repository has been archived by the owner on Sep 28, 2023. It is now read-only.

Cookie Consent #18

Closed
liyokuna opened this issue Jan 24, 2019 · 7 comments
Closed

Cookie Consent #18

liyokuna opened this issue Jan 24, 2019 · 7 comments

Comments

@liyokuna
Copy link

Due to the RGPD, we need to add a cookie consent.
Boosted cookie consent can be an example.

@liyokuna liyokuna self-assigned this Jan 24, 2019
@liyokuna liyokuna added this to To Do in Ng-Boosted 4.0.1-beta.1 via automation Jan 24, 2019
@liyokuna liyokuna moved this from To Do to In Progress in Ng-Boosted 4.0.1-beta.1 Jan 24, 2019
@liyokuna
Copy link
Author

No cookies are created.
npm package that can help for further use.
https://www.npmjs.com/package/cookieconsent

Ng-Boosted 4.0.1-beta.1 automation moved this from In Progress to Done Jan 24, 2019
@liyokuna liyokuna moved this from Done to In Progress in Ng-Boosted 4.0.1-beta.1 Feb 4, 2019
@liyokuna liyokuna reopened this Feb 5, 2019
Ng-Boosted 4.0.1-beta.1 automation moved this from In Progress to To Do Feb 5, 2019
@liyokuna
Copy link
Author

liyokuna commented Feb 5, 2019

using this cookie consent package
https://tinesoft.github.io/ngx-cookieconsent/getting-started

@liyokuna liyokuna moved this from To Do to In Progress in Ng-Boosted 4.0.1-beta.1 Feb 5, 2019
liyokuna pushed a commit that referenced this issue Feb 5, 2019
liyokuna pushed a commit that referenced this issue Feb 7, 2019
zero cookies generated so far
@liyokuna liyokuna closed this as completed Feb 7, 2019
Ng-Boosted 4.0.1-beta.1 automation moved this from In Progress to Done Feb 7, 2019
@liyokuna liyokuna reopened this Apr 11, 2019
@liyokuna liyokuna added this to To DO in 4.1.3 via automation Apr 11, 2019
@liyokuna liyokuna moved this from To DO to In Progress in 4.1.3 Apr 12, 2019
liyokuna pushed a commit that referenced this issue Apr 15, 2019
@liyokuna liyokuna moved this from In Progress to To be tested in 4.1.3 Apr 19, 2019
@liyokuna
Copy link
Author

Hello @Aniort ,

I need you to test the accessiblity of the pop over cookie.
here is the link.

@Aniort
Copy link

Aniort commented Apr 19, 2019

not validated :

  • you must remove aria-label="cookieconsent" from the div (aria-labelledby is enough)
  • you do you use links with ria roles of button instead of real buttons
  • you don't need aria-label in these links because text links are understandables, but if you want to use aria-label translate them
  • you must put the text of the popup and the links inside a

    tag

  • translate the "learn more" link

@liyokuna
Copy link
Author

Hello @Aniort,
can you check all the changes right here.

@liyokuna
Copy link
Author

Hello @StreiffBerenice , Check the accessibility of the pop up, please.
here is the link

@StreiffBerenice
Copy link

This is what I see when I activate yout link I don't understand what do you expect.
image

@liyokuna liyokuna moved this from To be tested to Waiting in 4.1.3 May 14, 2019
@liyokuna liyokuna removed this from Waiting in 4.1.3 May 22, 2019
@liyokuna liyokuna added this to To Do in 4.2.0 via automation May 22, 2019
@liyokuna liyokuna moved this from To Do to On Hold in 4.2.0 Jun 14, 2019
@liyokuna liyokuna removed this from On Hold in 4.2.0 Jun 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
No open projects
Development

No branches or pull requests

3 participants