Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🆕 Sticker component #1023

Merged
merged 17 commits into from
Mar 1, 2022
Merged

🆕 Sticker component #1023

merged 17 commits into from
Mar 1, 2022

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Jan 6, 2022

Closes #440

Agreed with the designers that we can simply implement a container without placing elements with pixel perfect.

Live Previews

DoD

Development

  • Should match specs (eg. either the Web UI Kit or any pattern from the WAI — or both…)
  • Docs added:
    • including the "Sass" part using scss-docs shortcode
    • in /about/overview/#custom-components if it is a new Orange custom component
    • in /getting-started/introduction/#components if it is a new Orange custom component that requires JavaScript (and Popper)
    • in /customize/overview#csps-and-embedded-svgs if it is a new Orange custom component that includes embedded SVGs in our CSS
    • in /forms/validation/?#supported-elements if it is a new Orange custom component that is a form control
    • in /forms/overview/ if it is a new Orange custom component that is a form control
  • Check (and fix) RTL version
  • Run linters
  • Run compilers
  • Manually run BrowserStack test
  • Manually run Percy test
  • Cross-browser test:
    • Firefox ESR
    • Latest Edge, Chrome, Firefox, Safari
    • iOS Safari
    • Chrome & Firefox on Android

Reviews

  • Code review
  • A11y review
  • Design review
    • Update the thumbnails after the design review

scss/_variables.scss Outdated Show resolved Hide resolved
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the responsive size of font-size wanted ? -> Many spacing issues in small viewports
Maybe put a line to tell that utilities works on .sticker too ?

scss/_variables.scss Outdated Show resolved Hide resolved
site/content/docs/5.1/examples/stickers/index.html Outdated Show resolved Hide resolved
site/content/docs/5.1/examples/stickers/index.html Outdated Show resolved Hide resolved
site/content/docs/5.1/examples/stickers/index.html Outdated Show resolved Hide resolved
site/content/docs/5.1/examples/stickers/index.html Outdated Show resolved Hide resolved
site/content/docs/5.1/examples/stickers/index.html Outdated Show resolved Hide resolved
site/content/docs/5.1/examples/stickers/index.html Outdated Show resolved Hide resolved
site/content/docs/5.1/examples/stickers/index.html Outdated Show resolved Hide resolved
site/content/docs/5.1/examples/stickers/index.html Outdated Show resolved Hide resolved
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me.

@julien-deramond
Copy link
Member Author

julien-deramond commented Jan 14, 2022

  • A11y feedback from @Aniort: include the sticker's content within a <p> for semantics.

@julien-deramond
Copy link
Member Author

julien-deramond commented Jan 20, 2022

  • Last thing to do in this PR: explain that our example in not a responsive example and is just a simple example with utility classes that works for desktop.

@julien-deramond julien-deramond merged commit b466b27 into main Mar 1, 2022
@julien-deramond julien-deramond deleted the main-jd-stickers branch March 1, 2022 14:45
@julien-deramond julien-deramond mentioned this pull request Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ODS > Stickers
3 participants