implement default focus-visible #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doesn't only relies on polyfill focus-visible but also implement native :focus-visible
Using the :focus-visible pseudo-class if supported by the browser, duplicate the css code, in case the browser doesn't implement it, won't break the polyfill directive
julien-deramond
force-pushed
the
Lausselloic-patch-focus-visible
branch
from
9cd45c6
to
f013526
Compare
julien-deramond
approved these changes
Mar 7, 2022
There was a problem hiding this comment.
Haven't seen any regressions so LGTM! 🚀
Thx for this enhancement :)
FYI, I subscribed to WICG/focus-visible#237; it will probably have an impact on this file as well in the future.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doesn't only relies on polyfill focus-visible but also implement native :focus-visible
https://caniuse.com/css-focus-visible support is not so bad at time