Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pagination): change background position of arrow icon, and global… #1155

Merged
merged 7 commits into from
Apr 1, 2022

Conversation

hannahiss
Copy link
Member

change background position of arrow icon, and globally all icon-buttons, of 1 pixel so has it is well centered

closes #1119

@louismaximepiton
Copy link
Member

⚠️ Be careful here, this changes affect : Back-to-top, social buttons, carousel, close-button, quantity selector and also tarteaucitron. I think you could maybe handle the changes directly in _pagination.scss.

@hannahiss hannahiss self-assigned this Mar 24, 2022
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think back-to-top should be in another PR, the remaining sounds good to me !

scss/_back-to-top.scss Outdated Show resolved Hide resolved
@hannahiss
Copy link
Member Author

Ok pushed again with only pagination icon modification

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@julien-deramond
Copy link
Member

LGTM 🚀

@hannahiss This issue seems to be there in v4 as well. If you confirm, could you create a PR to fix v4 as well?

@julien-deramond julien-deramond merged commit fc2b2b2 into main Apr 1, 2022
@julien-deramond julien-deramond deleted the main-his-pagination-arrows branch April 1, 2022 10:58
@julien-deramond julien-deramond mentioned this pull request Apr 1, 2022
@julien-deramond julien-deramond added this to In progress in v4.6.2 via automation Apr 4, 2022
@julien-deramond julien-deramond moved this from In progress to Backport to v4 in v4.6.2 Apr 4, 2022
@julien-deramond julien-deramond moved this from Backport to v4 to Done in v4.6.2 Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Docs > Components > Pagination > Working with icons: Fix css
3 participants