Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(social-btn): add white border on dark background #1166

Merged
merged 4 commits into from
Apr 4, 2022

Conversation

hannahiss
Copy link
Member

@hannahiss hannahiss commented Mar 25, 2022

fix(social-btn): on dark background,need a white border so that the size of button doesn't decrease.
Closes #1121

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

scss/_buttons.scss Outdated Show resolved Hide resolved
@julien-deramond julien-deramond merged commit 9cf814f into main Apr 4, 2022
@julien-deramond julien-deramond deleted the main-his-social-border-on-dark branch April 4, 2022 06:05
@julien-deramond
Copy link
Member

@hannahiss Could you backport it in v4 as well?

@julien-deramond julien-deramond mentioned this pull request Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs > Components > Buttons > Dark background: Fix border color for social buttons on active state
3 participants