fix(pagination): set margin between numbers to 0 #1179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See #1154 |
This comment was marked as off-topic.
This comment was marked as off-topic.
|
@louismaximepiton : j'ai changé de PR car je ne m'en sortais pas avec l'autre. Tu trouveras normalement ici les bonnes modifications pour la #1120. Merci pour ta relecture :-) |
louismaximepiton
requested changes
Apr 7, 2022
louismaximepiton
requested changes
Apr 29, 2022
… for margin at start and end (before and after numbers). Naming to see
… for margin at start and end (before and after numbers). Naming to see
… for margin at start and end (before and after numbers).
julien-deramond
force-pushed
the
main-his-pagination-numbers-margin2
branch
from
7db98bc
to
374761a
Compare
julien-deramond
approved these changes
May 2, 2022
Closed
The space between numbers in pagination is already ok in v4 so no need to backport |
|
Are you sure? I have this on
|
|
You're right... Sorry it's monday morning... I'll have a look to check how much this is complicated to fix in v4... |
hannahiss
added a commit
that referenced
this pull request
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and add new variable for margins at start and end (before and after numbers).
Naming to see for this variable
I also had to correct line 107 to be able to commit (was sending an error), conforming to higher in the file.
closes #1120