Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(color): add indigo to colors (existing but not documented). #1226

Merged
merged 3 commits into from
May 2, 2022
Merged

fix(color): add indigo to colors (existing but not documented). #1226

merged 3 commits into from
May 2, 2022

Conversation

hannahiss
Copy link
Member

@hannahiss hannahiss commented Apr 29, 2022 •
edited

Closes #1225

@hannahiss hannahiss mentioned this pull request Apr 29, 2022
Closed
louismaximepiton
louismaximepiton approved these changes Apr 29, 2022
View reviewed changes
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I would have wrote something like: ... the indigo colors are the same as the purple ones. But as-is looks fine to me.

@hannahiss
Copy link
Member Author

LGTM, I would have wrote something like: ... the indigo colors are the same as the purple ones. But as-is looks fine to me.
C'est un projet complet, on apprend l'anglais aussi ;-)

@julien-deramond julien-deramond added v5 docs Improvements or additions to documentation fix labels May 2, 2022
@julien-deramond julien-deramond self-requested a review May 2, 2022 06:32
@julien-deramond julien-deramond merged commit 6d893e1 into main May 2, 2022
@julien-deramond julien-deramond deleted the main-his-indigo-color branch May 2, 2022 06:39
@julien-deramond julien-deramond mentioned this pull request May 2, 2022
Closed
hannahiss added a commit that referenced this pull request May 19, 2022
@hannahiss @julien-deramond
fix(doc): add existing indigo to the colors list (#1226)
2aca76a 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

@louismaximepiton louismaximepiton louismaximepiton approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to documentation fix v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs > Customize > Color: $indigo is missing in All colors.
3 participants
@hannahiss @julien-deramond @louismaximepiton