Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Footer css var #1239

Merged
merged 18 commits into from
Jul 27, 2022
Merged

Footer css var #1239

merged 18 commits into from
Jul 27, 2022

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented May 5, 2022

Closes #1220

Commits can be split if needed

@netlify
Copy link

netlify bot commented May 16, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 93ac166
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/62e0e33f1a80df00085b6015
😎 Deploy Preview https://deploy-preview-1239--boosted.netlify.app/docs/5.2/components/footer
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member Author

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have some few questions

scss/_footer.scss Outdated Show resolved Hide resolved
scss/_footer.scss Outdated Show resolved Hide resolved
scss/_footer.scss Outdated Show resolved Hide resolved
site/layouts/shortcodes/orange-footer.html Show resolved Hide resolved
site/layouts/shortcodes/orange-global-headers.html Outdated Show resolved Hide resolved
scss/_navbar.scss Show resolved Hide resolved
@MewenLeHo MewenLeHo self-requested a review July 25, 2022 07:54
scss/_footer.scss Outdated Show resolved Hide resolved
@julien-deramond julien-deramond self-requested a review July 27, 2022 07:20
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't seen any other regressions. LGTM! Good job @louismaximepiton!

@julien-deramond julien-deramond merged commit 4260603 into main Jul 27, 2022
@julien-deramond julien-deramond deleted the main-lmp-footer-css-var branch July 27, 2022 07:26
@julien-deramond julien-deramond mentioned this pull request Jul 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS var for Footer
3 participants