Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dropdowns): Add CSS vars for $dropdown #1279

Merged
merged 7 commits into from
Jul 22, 2022

Conversation

isabellechanclou
Copy link
Member

@isabellechanclou isabellechanclou commented May 24, 2022

Add CSS vars for Dropdowns components.

@netlify
Copy link

netlify bot commented May 24, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit d1ea762
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/62daac923280590008a5c995
😎 Deploy Preview https://deploy-preview-1279--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there, 3 few things to tackle

scss/_dropdown.scss Outdated Show resolved Hide resolved
site/content/docs/5.1/components/dropdowns.md Outdated Show resolved Hide resolved
scss/_dropdown.scss Outdated Show resolved Hide resolved
scss/_dropdown.scss Show resolved Hide resolved
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we had a small misunderstanding with the last commit

scss/_dropdown.scss Outdated Show resolved Hide resolved
site/content/docs/5.1/components/dropdowns.md Outdated Show resolved Hide resolved
site/content/docs/5.1/components/dropdowns.md Outdated Show resolved Hide resolved
site/content/docs/5.1/components/dropdowns.md Outdated Show resolved Hide resolved
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
Copy link
Contributor

@MewenLeHo MewenLeHo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌

@julien-deramond julien-deramond merged commit 82ed37d into main Jul 22, 2022
@julien-deramond julien-deramond deleted the main-ic-css-variables-dropdowns branch July 22, 2022 14:08
@julien-deramond julien-deramond mentioned this pull request Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants