Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS var: stepped process #1281

Merged
merged 10 commits into from
Jul 19, 2022
Merged

CSS var: stepped process #1281

merged 10 commits into from
Jul 19, 2022

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented May 25, 2022

CSS var for stepped process

@netlify
Copy link

netlify bot commented May 25, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit c94be7b
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/62d64608e4d1410008010d7f
😎 Deploy Preview https://deploy-preview-1281--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member Author

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On hold until there's an answer for the second comment

scss/_stepped-process.scss Outdated Show resolved Hide resolved
scss/_stepped-process.scss Outdated Show resolved Hide resolved
@louismaximepiton

This comment was marked as outdated.

@louismaximepiton louismaximepiton marked this pull request as ready for review June 1, 2022 08:20
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't finished the technical review (CSS vars) but here are some first feedback.

I think the result observed in this PR is better but is it normal that the visible focus has changed? Not at all breakpoints but the shape is sometimes different (smaller).

scss/_stepped-process.scss Outdated Show resolved Hide resolved
scss/_stepped-process.scss Outdated Show resolved Hide resolved
scss/_variables.scss Outdated Show resolved Hide resolved
scss/_variables.scss Outdated Show resolved Hide resolved
@julien-deramond
Copy link
Member

@louismaximepiton Reverted the creation of --#{$prefix}stepped-process-max-items via c94be7b because of @for $i from 1 through $stepped-process-max-items {. Indeed you won't be able to change the behavior of this loop by changing only the CSS var and having the value stored in this CSS var doesn't seem very useful in terms of reuse. We can discuss about that when you're back if I missed something and you want it to be reintroduced.

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Visible focus has changed but will be revisited via #1189.

@julien-deramond julien-deramond merged commit 45a280e into main Jul 19, 2022
@julien-deramond julien-deramond deleted the main-lmp-stepped-var branch July 19, 2022 06:14
@julien-deramond julien-deramond mentioned this pull request Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants