Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Card examples fix #1376

Merged
merged 25 commits into from Dec 7, 2022
Merged

Card examples fix #1376

merged 25 commits into from Dec 7, 2022

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Jul 8, 2022

Fixes #1327

Here is one solution to better fit design on documentation. I think that this solution is the best regarding the others I had. I'm open to discussion if you think that it would be better in another way 😄

@louismaximepiton louismaximepiton added v5 docs Improvements or additions to documentation fix labels Jul 8, 2022
@netlify
Copy link

netlify bot commented Jul 8, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 11ac6f2
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/63909e6d0c6daf00085b278d
😎 Deploy Preview https://deploy-preview-1376--boosted.netlify.app/docs/5.2/migration
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@MewenLeHo MewenLeHo self-requested a review July 22, 2022 13:46
Copy link
Contributor

@MewenLeHo MewenLeHo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@louismaximepiton louismaximepiton marked this pull request as ready for review July 26, 2022 07:09
@louismaximepiton
Copy link
Member Author

louismaximepiton commented Nov 23, 2022

Design review done. Some missing callouts that will be added with #1614 (comment) but will be added with #1199.

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A migration guide note should be added to talk about changes happening in the Cards component page and in the Cards example page; change of <h*> HTML tags, bold usage in which case, <button>s instead of <a>s, size of images, etc.

site/content/docs/5.2/examples/cards/index.html Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Dec 7, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
12.6% 12.6% Duplication

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks neat!

@julien-deramond julien-deramond merged commit f8772e1 into main Dec 7, 2022
@julien-deramond julien-deramond deleted the main-lmp-card-examples-fix branch December 7, 2022 14:14
@julien-deramond julien-deramond mentioned this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation fix passed design review v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs > Components > Card: Fix caption font + margin
3 participants