Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modal: Remove unused CSS variables #1418

Merged
merged 2 commits into from
Aug 24, 2022
Merged

Conversation

louismaximepiton
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Jul 27, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 4335e21
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/630611e6780c160008710ae2
😎 Deploy Preview https://deploy-preview-1418--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@julien-deramond
Copy link
Member

Maintenance question: isn't it "better" to keep the variables and set them to $btn-close-padding? It would be closer to Bootstrap.

.btn-close {
    margin: calc(#{$btn-close-padding} * -1) calc(#{$btn-close-padding} * -1) calc(#{$btn-close-padding} * -1) auto; // Boosted mod: using custom properties for padding
  }

@louismaximepiton
Copy link
Member Author

That's a good question and I don't have the answer right now. Maybe it's better, I'll give it a try !

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it like this for the moment. It is consistent with other files: _accordion.scss, _list-group.scss and _navbar.scss.

@julien-deramond julien-deramond merged commit 1251579 into main Aug 24, 2022
@julien-deramond julien-deramond deleted the main-lmp-modal-trim branch August 24, 2022 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants