Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alerts height #1425

Merged
merged 3 commits into from
Aug 23, 2022

Conversation

MewenLeHo
Copy link
Contributor

@MewenLeHo MewenLeHo commented Jul 28, 2022

Closes #1324

@MewenLeHo MewenLeHo self-assigned this Jul 28, 2022
@MewenLeHo MewenLeHo marked this pull request as draft July 28, 2022 08:17
@netlify
Copy link

netlify bot commented Jul 28, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit c2e2031
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/63048d0d72fe120009d5c6f5
😎 Deploy Preview https://deploy-preview-1425--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@MewenLeHo MewenLeHo closed this Jul 28, 2022
@MewenLeHo MewenLeHo force-pushed the main-mlh-alerts-add-close-button-and-fix-height branch from 41921bd to 78d7d14 Compare July 28, 2022 13:25
@MewenLeHo MewenLeHo reopened this Jul 28, 2022
@MewenLeHo MewenLeHo changed the title Add close buttons to alerts and fix height Fix alerts height Jul 28, 2022
@MewenLeHo MewenLeHo force-pushed the main-mlh-alerts-add-close-button-and-fix-height branch from 8ce7c79 to 9de2344 Compare July 28, 2022 14:38
@MewenLeHo MewenLeHo marked this pull request as ready for review July 28, 2022 15:47
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few things

scss/_alert.scss Outdated Show resolved Hide resolved
scss/_alert.scss Outdated Show resolved Hide resolved
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julien-deramond julien-deramond merged commit 29e5250 into main Aug 23, 2022
@julien-deramond julien-deramond deleted the main-mlh-alerts-add-close-button-and-fix-height branch August 23, 2022 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs > Components > Alerts : Add a close button + fix height
3 participants