Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navs: Adding CSS var #1427

Merged
merged 7 commits into from
Oct 11, 2022
Merged

Navs: Adding CSS var #1427

merged 7 commits into from
Oct 11, 2022

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Jul 28, 2022

Commits can be reviewed separately and/or can be split if needed.

The second commit is a proposal but isn't mandatory IMO.

@netlify
Copy link

netlify bot commented Jul 28, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 464f89f
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/63456e83410eb900089d33c2
😎 Deploy Preview https://deploy-preview-1427--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@louismaximepiton louismaximepiton marked this pull request as ready for review July 28, 2022 15:08
scss/_nav.scss Outdated Show resolved Hide resolved
Copy link
Member

@isabellechanclou isabellechanclou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (both commits) even though a slight comment on the 2nd commit.

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. Just a comment regarding the naming of one of the CSS vars.

scss/_nav.scss Outdated Show resolved Hide resolved
@julien-deramond julien-deramond added this to Triage in v5.2.1 via automation Oct 11, 2022
@julien-deramond julien-deramond moved this from Triage to In progress in v5.2.1 Oct 11, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 11, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julien-deramond julien-deramond merged commit 6ca8d1a into main Oct 11, 2022
@julien-deramond julien-deramond deleted the main-lmp-navs-css-var branch October 11, 2022 13:32
@louismaximepiton louismaximepiton moved this from In progress to Done in v5.2.1 Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants