-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navs: Adding CSS var #1427
Navs: Adding CSS var #1427
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (both commits) even though a slight comment on the 2nd commit.
4926de3
to
311a503
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good to me. Just a comment regarding the naming of one of the CSS vars.
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Commits can be reviewed separately and/or can be split if needed.
The second commit is a proposal but isn't mandatory IMO.