Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pagination: Adding dark variant #1433

Merged
merged 11 commits into from
Aug 31, 2022
Merged

Conversation

louismaximepiton
Copy link
Member

First draft idea: Add Scss var for each CSS var

@netlify
Copy link

netlify bot commented Jul 29, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 226c1db
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/630f07c67f2c88000853cac6
😎 Deploy Preview https://deploy-preview-1433--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@louismaximepiton louismaximepiton marked this pull request as ready for review August 1, 2022 08:32
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rendering LGTM!
Requested some minor changes in the documentation.
Please inform the designers that the DSM should be updated: the hover state for dark variant isn't described!

site/content/docs/5.2/components/pagination.md Outdated Show resolved Hide resolved
louismaximepiton and others added 2 commits August 23, 2022 11:42
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
@julien-deramond julien-deramond merged commit 3fb9a93 into main Aug 31, 2022
@julien-deramond julien-deramond deleted the main-lmp-pagination-dark-variant branch August 31, 2022 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants