Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-introduce thumbnail images #1441

Merged
merged 5 commits into from
Oct 13, 2022
Merged

Re-introduce thumbnail images #1441

merged 5 commits into from
Oct 13, 2022

Conversation

louismaximepiton
Copy link
Member

Wondering if we should introduce paragraph to explain how to manipulate thumbnails with utilities. IMHO we don't need it but I prefer to ask.

@louismaximepiton louismaximepiton added v5 docs Improvements or additions to documentation labels Aug 5, 2022
@netlify
Copy link

netlify bot commented Aug 5, 2022 •
edited

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 16c8608
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6346bfc8a8602300096469d9
😎 Deploy Preview https://deploy-preview-1441--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@louismaximepiton louismaximepiton mentioned this pull request Aug 5, 2022
Closed
MewenLeHo
MewenLeHo approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@MewenLeHo MewenLeHo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@louismaximepiton
Copy link
Member Author

Returns from spec review:

  • The borders should be $gray-500
  • There should be no padding

@julien-deramond
Copy link
Member

Based on the IRL discussion we had today, this PR must be modified:

  • Remove the padding for img-thumbnail
  • Use a gray border instead of black
  • Use those thumbnails in the examples (based on cards actually)

@julien-deramond julien-deramond added this to Triage in v5.2.1 via automation Oct 11, 2022
@julien-deramond julien-deramond moved this from Triage to In progress in v5.2.1 Oct 11, 2022
@julien-deramond
Copy link
Member

@louismaximepiton Based on the last comment, I propose dfcc545 to remove the padding and change the border color.
I let you check the impacts wherever .img-thumbnail is used and tell me if this is OK for you. In this case, I'll merge this PR.

@louismaximepiton louismaximepiton mentioned this pull request Oct 12, 2022
Open
3 tasks
@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julien-deramond julien-deramond merged commit 344ab7e into main Oct 13, 2022
@julien-deramond julien-deramond deleted the main-lmp-thumbnails branch October 13, 2022 06:14
@julien-deramond julien-deramond mentioned this pull request Oct 13, 2022
Closed
@louismaximepiton louismaximepiton moved this from In progress to Done in v5.2.1 Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

@MewenLeHo MewenLeHo MewenLeHo approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to documentation v5
Projects
No open projects
v5.2.1
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@louismaximepiton @julien-deramond @MewenLeHo