feat(pagination): Remove CSS vars for $pagination after Bootstrap team review #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m review Signed-off-by: Isabelle Chanclou <isabelle.chanclou@orange.com>
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
louismaximepiton
approved these changes
Aug 12, 2022
julien-deramond
approved these changes
Aug 24, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposal to Bootstrap team to add 2 new css variables in their project (PR Add new css vars for Pagination #36816) as we did in Boosted (PR feat(pagination): Add CSS vars for $pagination #1268) was declined and the PR closed. In this PR, I'm therefore removing these 2 new css variables from Boosted to stay aligned with Bootstrap.