Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): inform users that Orange Helvetica CSS file names has changed in migration guide #1487

Merged
merged 5 commits into from
Aug 30, 2022

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Aug 29, 2022

Fixes #1107

This PR mentions in the migration guide that the Orange Helvetica CSS file names has changed between v4 and v5.

Live preview

@julien-deramond julien-deramond added v5 docs Improvements or additions to documentation fix labels Aug 29, 2022
@netlify
Copy link

netlify bot commented Aug 29, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit f96c1b1
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/630dfc6fc7be2c00090077d3
😎 Deploy Preview https://deploy-preview-1487--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@julien-deramond julien-deramond added this to Triage in v5.2.1 via automation Aug 30, 2022
@julien-deramond julien-deramond moved this from Triage to In progress in v5.2.1 Aug 30, 2022
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be changed in comment of rtl.md and scripts.html too!

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@julien-deramond julien-deramond merged commit d025921 into main Aug 30, 2022
@julien-deramond julien-deramond deleted the main-jd-migration-font-css branch August 30, 2022 12:08
@julien-deramond julien-deramond moved this from In progress to Done in v5.2.1 Oct 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation fix v5
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Wrong fonts files names
2 participants