Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare migration guide v5.2.0 → v5.2.1 #1522

Merged
merged 35 commits into from
Oct 31, 2022
Merged

Prepare migration guide v5.2.0 → v5.2.1 #1522

merged 35 commits into from
Oct 31, 2022

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Sep 8, 2022 •
edited

  • Integrate in comments all Bootstrap and Boosted commits
    • Latest commit integrated in this list is b7b16d5
  • Remove from this list things that are purely documentation updates
    • ⚠️ If the markups are modified in the documentation, it could mean that something should be integrated in the migration guide
  • Remove from this list things that modify the dependencies if they have no impact for the users
  • For each item, write an explanation to help the user migration from v5.2.0 to v5.2.1 (by trying to evaluate the impact)
    • Try to add temporarily a comment next to the new sentence in order for the reviewers to be able to go directly to the commit in Bootstrap or Boosted. Example is done for the back to top component
  • Group together topics than can for better readability. During a migration, users will tackle topics by topics.
  • Remove all comments before merging

/cc @louismaximepiton

Live preview

@julien-deramond julien-deramond added v5 docs Improvements or additions to documentation labels Sep 8, 2022
@julien-deramond julien-deramond added this to Triage in v5.2.1 via automation Sep 8, 2022
@netlify
Copy link

netlify bot commented Sep 8, 2022 •
edited

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit a20bb36
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/635fa0cac6311b000942c2d8
😎 Deploy Preview https://deploy-preview-1522--boosted.netlify.app/docs/5.2/migration
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@julien-deramond julien-deramond force-pushed the main-jd-migration-guide-5.2.0-to-5.2.1 branch from 279135c to 46b5bec Compare September 14, 2022 06:54
@louismaximepiton
Copy link
Member

Just a word about the failing CI: Due to CSS vars inside a comment.

@julien-deramond julien-deramond force-pushed the main-jd-migration-guide-5.2.0-to-5.2.1 branch from 039ecc9 to edbefe2 Compare October 20, 2022 11:14
@julien-deramond julien-deramond mentioned this pull request Oct 24, 2022
Merged
36 tasks
@julien-deramond julien-deramond moved this from Triage to In progress in v5.2.1 Oct 24, 2022
@julien-deramond julien-deramond force-pushed the main-jd-migration-guide-5.2.0-to-5.2.1 branch from b3e8ee6 to 7de0f2f Compare October 26, 2022 06:51
@julien-deramond julien-deramond force-pushed the main-jd-migration-guide-5.2.0-to-5.2.1 branch from 8ed7b19 to ada3376 Compare October 26, 2022 10:34
@julien-deramond julien-deramond marked this pull request as ready for review October 26, 2022 11:27
louismaximepiton
louismaximepiton reviewed Oct 27, 2022
View reviewed changes
site/content/docs/5.2/migration.md Outdated Show resolved Hide resolved
site/content/docs/5.2/migration.md Outdated Show resolved Hide resolved
site/content/docs/5.2/migration.md Outdated Show resolved Hide resolved
site/content/docs/5.2/migration.md Outdated Show resolved Hide resolved
site/content/docs/5.2/migration.md Outdated Show resolved Hide resolved
louismaximepiton
louismaximepiton approved these changes Oct 27, 2022
View reviewed changes
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more comment but it looks good to me 🚀

site/content/docs/5.2/migration.md Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Oct 31, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@julien-deramond julien-deramond merged commit 1586d9a into main Oct 31, 2022
@julien-deramond julien-deramond deleted the main-jd-migration-guide-5.2.0-to-5.2.1 branch October 31, 2022 10:20
@julien-deramond julien-deramond mentioned this pull request Oct 31, 2022
Closed
@julien-deramond julien-deramond moved this from In progress to Done in v5.2.1 Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louismaximepiton louismaximepiton louismaximepiton approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to documentation v5
Projects
No open projects
v5.2.1
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julien-deramond @louismaximepiton