Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close button: Adding CSS var #1531

Merged
merged 6 commits into from
Oct 12, 2022
Merged

Conversation

louismaximepiton
Copy link
Member

Related issues

#1196.

Description

Adding CSS var to close buttons.

Motivation & Context

Bootstrap probably won't do it on their side since they use filter for their variants. Moreover, we'll need them later to introduce more variants such as the outlined one.

Types of change

New feature (non-breaking change which adds functionality)

Live previews

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly

Development

  • Should match specs (eg. either the Web UI Kit or any pattern from the WAI — or both…)
  • Docs added:
    • including the "Sass" part using scss-docs shortcode
    • in /about/overview/#custom-components if it is a new Orange custom component
    • in /getting-started/introduction/#components if it is a new Orange custom component that requires JavaScript (and Popper)
    • in /customize/overview#csps-and-embedded-svgs if it is a new Orange custom component that includes embedded SVGs in our CSS
    • in /forms/validation/?#supported-elements if it is a new Orange custom component that is a form control
    • in /forms/overview/ if it is a new Orange custom component that is a form control
  • Check (and fix) RTL version
  • Run linters
  • Run compilers
  • Tests added for JS-side
  • Run tests
  • Manually run BrowserStack test
  • Manually run Percy test
  • Cross-browser test:
    • Chrome
    • Firefox (including ESR)
    • Edge
    • Safari
    • iOS Safari
    • Chrome & Firefox on Android
  • Responsive tests: desktop and small screens
  • Clean up the branch using rebase -i
  • Commited with feat(…): … message
  • Mention it in Migration Guide (if back-from-v4): renamed variables, changes in markup requirement, etc.

Reviews

  • Code review
  • A11y review
  • Design review

@louismaximepiton louismaximepiton added v5 docs Improvements or additions to documentation css labels Sep 13, 2022
@netlify
Copy link

netlify bot commented Sep 13, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 7205557
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/632053278c4b9d0008a7a02d
😎 Deploy Preview https://deploy-preview-1531--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 13, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 8c53bdf
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/63465e0d6ec2920008bbd4d5
😎 Deploy Preview https://deploy-preview-1531--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

site/content/docs/5.2/components/close-button.md Outdated Show resolved Hide resolved
site/content/docs/5.2/components/close-button.md Outdated Show resolved Hide resolved
site/content/docs/5.2/components/close-button.md Outdated Show resolved Hide resolved
scss/_close.scss Outdated Show resolved Hide resolved
@julien-deramond julien-deramond added this to Triage in v5.2.1 via automation Oct 10, 2022
@julien-deramond julien-deramond moved this from Triage to In progress in v5.2.1 Oct 10, 2022
@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@julien-deramond julien-deramond merged commit 2aef590 into main Oct 12, 2022
@julien-deramond julien-deramond deleted the main-lmp-close-btn-css-var branch October 12, 2022 06:34
@louismaximepiton louismaximepiton moved this from In progress to Done in v5.2.1 Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css docs Improvements or additions to documentation v5
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants