Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Bootstrap examples unused in Boosted #1542

Merged
merged 9 commits into from
Oct 12, 2022

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Oct 11, 2022

Description

Remove all Bootstrap examples unused in Boosted (that were already hidden).

Motivation & Context

  • Will reduce the size of the branches
  • Probably won't be referenced in terms of SEO anymore
  • Having results in my editor in the examples while searching for classes bothers me 😇

Types of change

  • Refactoring (non-breaking change)

Live previews

All those pages should be a 404 page:

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • All new and existing tests passed

@julien-deramond julien-deramond added v5 docs Improvements or additions to documentation labels Oct 11, 2022
@julien-deramond julien-deramond added this to Triage in v5.2.1 via automation Oct 11, 2022
@netlify
Copy link

netlify bot commented Oct 11, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit cea1bac
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6346b5a7763278000c462e22
😎 Deploy Preview https://deploy-preview-1542--boosted.netlify.app/docs/5.2/getting-started/rtl
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@julien-deramond julien-deramond moved this from Triage to In progress in v5.2.1 Oct 11, 2022
@julien-deramond julien-deramond marked this pull request as ready for review October 11, 2022 11:09
@julien-deramond

This comment was marked as resolved.

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a link inside https://main--boosted.netlify.app/docs/5.2/getting-started/rtl/#rtl-examples which aren't in Boosted anymore

@sonarcloud
Copy link

sonarcloud bot commented Oct 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@julien-deramond julien-deramond merged commit a00919d into main Oct 12, 2022
@julien-deramond julien-deramond deleted the main-jd-remove-unused-examples branch October 12, 2022 12:50
@louismaximepiton louismaximepiton moved this from In progress to Done in v5.2.1 Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation v5
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants