Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add design callouts in all the documentation when incompatibility with ODS #1614

Open
wants to merge 71 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 54 commits
Commits
Show all changes
71 commits
Select commit Hold shift + click to select a range
b8a48d8
Add design callout messages everywhere needed
isabellechanclou Nov 9, 2022
fda5e4e
Add link on the callout title to go to the explanation of the presenc…
isabellechanclou Nov 9, 2022
fee6364
Fix the lineheight of callout text.
isabellechanclou Nov 10, 2022
867e9a5
Add design callout message in Customize/Color
isabellechanclou Nov 10, 2022
aa70535
Fix Buttons design callout message.
isabellechanclou Nov 10, 2022
798f1f3
Add design callout message in Button/Sizes custom size variant
isabellechanclou Nov 10, 2022
4a1d317
Add missing callout message in Docs>Components>Badge
isabellechanclou Nov 14, 2022
350c3f9
Fix word spelling
isabellechanclou Nov 14, 2022
8b84244
Fix link in a callout message for Badge component
isabellechanclou Nov 14, 2022
0bfbb44
Fix list-group/#numbered callout message
isabellechanclou Nov 14, 2022
2112c38
Fix Badges design callout messages after review
isabellechanclou Nov 25, 2022
3f3bd2a
Fix Breadcrumb design callout messages after review
isabellechanclou Nov 25, 2022
33fc463
Fix Button-group design callout messages after review
isabellechanclou Nov 25, 2022
ab28cf2
Remove h4 tag from design callout title
isabellechanclou Nov 28, 2022
885c070
Fix Buttons design callout messages + Add a design callout message in…
isabellechanclou Nov 28, 2022
0736e55
Fix Dropdowns design callout messages after review
isabellechanclou Nov 29, 2022
dea2716
Fix Modals design callout messages after review
isabellechanclou Nov 29, 2022
34a7060
Fix Carousel design callout messages after review
isabellechanclou Nov 29, 2022
c9426ab
Fix Progress design callout messages after review
isabellechanclou Nov 29, 2022
3c5232c
Fix Tooltip design callout messages after review
isabellechanclou Nov 29, 2022
cd0cf7b
Fix Reboot design callout messages after review
isabellechanclou Nov 29, 2022
fa4be81
Fix Color design callout messages after review
isabellechanclou Nov 29, 2022
2ce1f27
Fix Form control design callout messages after review
isabellechanclou Dec 2, 2022
f455984
Fix Input-group design callout messages after review
isabellechanclou Dec 2, 2022
c55605e
Fix Form/Layout design callout messages after review
isabellechanclou Dec 2, 2022
f3706df
Fix Form/Overview design callout messages after review
isabellechanclou Dec 5, 2022
13a9d53
Fix Form/Select design callout messages after review
isabellechanclou Dec 5, 2022
6a087c2
Fix Form/Validation design callout messages after review
isabellechanclou Dec 5, 2022
8cd8a84
Fix Introduction design callout messages after review
isabellechanclou Dec 5, 2022
ea144cf
Fix Breadcrumb design callout messages after review
isabellechanclou Dec 5, 2022
eb3cc22
Fix Button-group design callout messages after review
isabellechanclou Dec 5, 2022
5e33f1b
Fix Carousel design callout messages after review
isabellechanclou Dec 5, 2022
eac00f1
Fix Buttons design callout messages after review
isabellechanclou Dec 5, 2022
5472045
Fix Colors design callout messages after review
isabellechanclou Dec 5, 2022
bc01e55
Fix Dropdowns design callout messages after review
isabellechanclou Dec 5, 2022
39193ea
Fix Form control design callout messages after review
isabellechanclou Dec 5, 2022
de8fc8f
Fix Input group design callout messages after review
isabellechanclou Dec 5, 2022
7a4e7e4
Fix Introduction design callout messages after review
isabellechanclou Dec 5, 2022
74a336e
Fix Form/Overview design callout messages after review
isabellechanclou Dec 6, 2022
b819d38
Fix Modal design callout messages after review
isabellechanclou Dec 6, 2022
f9b896e
Fix Badge design callout messages after review
isabellechanclou Dec 7, 2022
2e9b718
Fix Progress design callout messages after review
isabellechanclou Dec 7, 2022
b19eb41
Fix Tooltips design callout messages after review
isabellechanclou Dec 7, 2022
5d3b634
Fix Form/Select design callout messages after review
isabellechanclou Dec 7, 2022
776708e
Fix Form/Validation design callout messages after review
isabellechanclou Dec 7, 2022
4480ba8
Fix Collapse design callout messages after review
isabellechanclou Dec 8, 2022
20e6a3a
Fix Nav-tabs design callout messages after review
isabellechanclou Dec 8, 2022
512eca4
Fix List-group design callout messages after review
isabellechanclou Dec 8, 2022
8c550e9
Fix design callout messages after review
isabellechanclou Dec 15, 2022
2443926
Fix design callout messages after review
isabellechanclou Dec 16, 2022
d59bb75
Merge branch 'main' into main-ic-add-design-callouts-in-docs
isabellechanclou Dec 16, 2022
e396a16
Merge branch 'main' into main-ic-add-design-callouts-in-docs
julien-deramond Dec 22, 2022
15c1a80
Drop Boosted mod comments
julien-deramond Dec 22, 2022
f8936ce
Fix design callout messages after dev and design review
isabellechanclou Feb 2, 2023
244f780
Update site/content/docs/5.2/forms/form-control.md
isabellechanclou Mar 10, 2023
7298b38
Update site/content/docs/5.2/forms/input-group.md
isabellechanclou Mar 10, 2023
a72a977
Fix design callout messages after dev and design review
isabellechanclou Mar 10, 2023
0be5ae2
Merge branch 'main' into main-ic-add-design-callouts-in-docs
isabellechanclou Mar 13, 2023
651d6ed
Merge remote-tracking branch 'origin/main-ic-add-design-callouts-in-d…
isabellechanclou Mar 14, 2023
454457a
Merge branch 'main' into main-ic-add-design-callouts-in-docs
isabellechanclou Mar 14, 2023
83942cc
Replace {{< ods-incompatibility-alert >}} by {{< design-callout-alert…
isabellechanclou Mar 14, 2023
28b2ce7
Add design callout messages in Spinner component
isabellechanclou Mar 14, 2023
fda225f
Adding and fixing design callout messages for input fieds of 30px height
isabellechanclou Mar 15, 2023
62c76a4
Fixing more design callout messages
isabellechanclou Mar 16, 2023
7b7c035
Merge branch 'main' into main-ic-add-design-callouts-in-docs for havi…
isabellechanclou Mar 20, 2023
ed643d8
Merge branch 'main' into main-ic-add-design-callouts-in-docs
isabellechanclou Mar 27, 2023
de08a1c
Fixes
isabellechanclou Apr 13, 2023
57faa2d
Merge branch 'main' into main-ic-add-design-callouts-in-docs
isabellechanclou Apr 13, 2023
36716cf
Merge branch 'main' into main-ic-add-design-callouts-in-docs
isabellechanclou Apr 17, 2023
5632d11
Merge branch 'main' into main-ic-add-design-callouts-in-docs
louismaximepiton Jan 4, 2024
4fcd51d
Proposal
louismaximepiton Jan 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 8 additions & 2 deletions site/content/docs/5.2/components/button-group.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,9 +61,9 @@ Please refer to our Boosted [Buttons]({{< docsref "/components/buttons#examples"
Combine button-like checkbox and radio [toggle buttons]({{< docsref "/forms/checks-radios" >}}) into a seamless looking button group.

{{< ods-incompatibility-alert >}}
This **checkbox** variant should not be used because it does not respect the Orange Design System specifications.
These **checkbox** and **radio button** variants should not be used because they do not respect the Orange Design System specifications.

From the Orange Design System point of view, checkboxes should be represented like in our Boosted [Checks]({{< docsref "/forms/checks-radios#checks" >}}) component. You can also refer to the [Checkbox](https://system.design.orange.com/0c1af118d/p/88ab5b-forms/b/599459/i/48901789) guidelines on the Orange Design System website.
From the Orange Design System point of view, checkboxes and radio buttons should respectively be represented like in our Boosted [Checks]({{< docsref "/forms/checks-radios#checks" >}}) or [Radios]({{< docsref "/forms/checks-radios#radios" >}}) components. You can also refer to the [Checkbox](https://system.design.orange.com/0c1af118d/p/88ab5b-forms/b/599459/i/48901789) and [Radio button](https://system.design.orange.com/0c1af118d/p/88ab5b-forms/b/599459/i/48901789) guidelines on the Orange Design System website.
isabellechanclou marked this conversation as resolved.
Show resolved Hide resolved
{{< /ods-incompatibility-alert >}}

{{< example >}}
Expand Down Expand Up @@ -153,6 +153,12 @@ Feel free to mix input groups with button groups in your toolbars. Similar to th

Instead of applying button sizing classes to every button in a group, just add `.btn-group-*` to each `.btn-group`, including each one when nesting multiple groups.

{{< ods-incompatibility-alert >}}
The **first size variant (50px height) and the last one (30px height)** should not be used because they do not respect the Orange Design System specifications.

Please refer to the [Toggle buttons](https://system.design.orange.com/0c1af118d/p/59c349-toggle-buttons/b/91bf23) guidelines on the Orange Design System website.
{{< /ods-incompatibility-alert >}}

{{< example >}}
<div class="btn-group btn-group-lg" role="group" aria-label="Large button group">
<button type="button" class="btn btn-secondary">Left</button>
Expand Down
2 changes: 1 addition & 1 deletion site/content/docs/5.2/components/buttons.md
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ Additional utilities can be used to adjust the alignment of buttons when horizon
The button plugin allows you to create simple on/off toggle buttons.

{{< ods-incompatibility-alert >}}
These variants with only **one toggle button** should not be used because they do not respect the Orange Design System specifications. From the Orange Design System point of view and for usability reasons, a toggle button should not be used alone.
These variants with only **one toggle button instead of a group of buttons** should not be used because they do not respect the Orange Design System specifications. From the Orange Design System point of view and for usability reasons, [Toggle buttons](https://system.design.orange.com/0c1af118d/p/59c349-toggle-buttons/b/91bf23) should not be used alone.

Instead, consider using our Boosted [Checks]({{< docsref "/forms/checks-radios#checks" >}}), [Radios]({{< docsref "/forms/checks-radios#radios" >}}) or [Radio toggle buttons]({{< docsref "/forms/checks-radios#radio-toggle-buttons" >}}) components.
{{< /ods-incompatibility-alert >}}
Expand Down
1 change: 1 addition & 0 deletions site/content/docs/5.2/components/collapse.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ Triggering a collapse behavior from a button component should not be used becaus
{{< partial "callout-info-prefersreducedmotion.md" >}}
{{< /callout >}}


isabellechanclou marked this conversation as resolved.
Show resolved Hide resolved
## Example

Click the buttons below to show and hide another element via class changes:
Expand Down
14 changes: 13 additions & 1 deletion site/content/docs/5.2/components/dropdowns.md
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,12 @@ This small variant should not be used because it does not respect the Orange Des
Please refer to the [Dropdown](https://system.design.orange.com/0c1af118d/p/910b9b-dropdown/b/04c480) guidelines on the Orange Design System website.
{{< /ods-incompatibility-alert >}}

{{< ods-incompatibility-alert >}}
This small variant should not be used because it does not respect the Orange Design System specifications.

Please refer to the [Dropdown](https://system.design.orange.com/0c1af118d/p/910b9b-dropdown/b/04c480) guidelines on the Orange Design System website.
{{< /ods-incompatibility-alert >}}

louismaximepiton marked this conversation as resolved.
Show resolved Hide resolved
<div class="bd-example">
<div class="btn-group">
<button class="btn btn-secondary btn-sm dropdown-toggle" type="button" data-bs-toggle="dropdown" aria-expanded="false">
Expand Down Expand Up @@ -510,7 +516,7 @@ You can use `<a>` or `<button>` elements as dropdown items.
</div>
{{< /example >}}

You can also create non-interactive dropdown items with `.dropdown-item-text`. Feel free to style further with custom CSS or text utilities.
You can also create non-interactive dropdown items with `.dropdown-item-text`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IDK why we would remove this specific sentence here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because we don't want users to do so. We want them to use the component the way it is in Boosted.


{{< example >}}
<ul class="dropdown-menu">
Expand Down Expand Up @@ -804,6 +810,12 @@ Please refer to the [Dropdown](https://system.design.orange.com/0c1af118d/p/910b

Use `data-bs-offset` or `data-bs-reference` to change the location of the dropdown.

{{< ods-incompatibility-alert >}}
This variant with a `data-bs-offset` attribute having values different than `"0,0"` should not be used because it does not respect the Orange Design System specifications.

Please refer to the [Dropdown](https://system.design.orange.com/0c1af118d/p/910b9b-dropdown/b/04c480) guidelines on the Orange Design System website.
{{< /ods-incompatibility-alert >}}

{{< example >}}
<div class="d-flex">
<div class="dropdown me-1">
Expand Down
6 changes: 6 additions & 0 deletions site/content/docs/5.2/components/list-group.md
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,12 @@ This variant, which is just an **example illustrating the use of the layout util

Use contextual classes to style list items with a stateful background and color.

{{< ods-incompatibility-alert >}}
louismaximepiton marked this conversation as resolved.
Show resolved Hide resolved
This variant should not be used as is because its rendering does not respect the Orange Design System specifications.
However, please note that the HTML markup remains valid and will be used as is when the [pull request #1452](https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/issues/1452) will be closed.

{{< /ods-incompatibility-alert >}}

{{< example >}}
<ul class="list-group">
<li class="list-group-item">A simple default list group item</li>
Expand Down
46 changes: 46 additions & 0 deletions site/content/docs/5.2/components/navs-tabs.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,12 @@ toc: true

## Base nav

{{< ods-incompatibility-alert >}}
isabellechanclou marked this conversation as resolved.
Show resolved Hide resolved
This component variant should not be used because it does not respect the Orange Design System specifications.

Instead, please consider using our Boosted [Tabs light]({{< docsref "/components/navs-tabs#tabs-light" >}}) variant. You can also refer to [Navigation](https://system.design.orange.com/0c1af118d/p/44331c-navigation/b/9105e6) guidelines on the Orange Design System website.
{{< /ods-incompatibility-alert >}}

Navigation available in Boosted share general markup and styles, from the base `.nav` class to the active and disabled states. Swap modifier classes to switch between each style.

The base `.nav` component is built with flexbox and provide a strong foundation for building all types of navigation components. It includes some style overrides (for working with lists), some link padding for larger hit areas, and basic disabled styling.
Expand All @@ -22,7 +28,14 @@ Note that the `.nav-link` can be used out of any context and combined with our [
The base `.nav` component does not include any `.active` state. The following examples include the class, mainly to demonstrate that this particular class does not trigger any special styling.

To convey the active state to assistive technologies, use the `aria-current` attribute — using the `page` value for current page, or `true` for the current item in a set.

{{< /callout >}}
<!-- Boosted mod : design callout -->
{{< ods-incompatibility-alert >}}
This component variant should not be used because it does not respect the Orange Design System specifications.

Instead, please consider using our Boosted [Tabs light]({{< docsref "/components/navs-tabs#tabs-light" >}}) variant. You can also refer to [Navigation](https://system.design.orange.com/0c1af118d/p/44331c-navigation/b/9105e6) guidelines on the Orange Design System website.
{{< /ods-incompatibility-alert >}}

{{< example >}}
<ul class="nav">
Expand Down Expand Up @@ -60,6 +73,13 @@ Change the style of `.nav`s component with modifiers and utilities. Mix and matc

Change the horizontal alignment of your nav with [flexbox utilities]({{< docsref "/layout/grid#horizontal-alignment" >}}). By default, navs are left-aligned, but you can easily change them to center or right aligned.

<!-- Boosted mod : design callout -->
{{< ods-incompatibility-alert >}}
These **centered** and **right aligned** component variants should not be used because they do not respect the Orange Design System specifications. Indeed, nav items should be left aligned.

Instead, please consider using our Boosted [Tabs light]({{< docsref "/components/navs-tabs#tabs-light" >}}) variant. You can also refer to [Navigation](https://system.design.orange.com/0c1af118d/p/44331c-navigation/b/9105e6) guidelines on the Orange Design System website.
louismaximepiton marked this conversation as resolved.
Show resolved Hide resolved
{{< /ods-incompatibility-alert >}}

Centered with `.justify-content-center`:

{{< example >}}
Expand Down Expand Up @@ -102,6 +122,13 @@ Right-aligned with `.justify-content-end`:

Stack your navigation by changing the flex item direction with the `.flex-column` utility. Need to stack them on some viewports but not others? Use the responsive versions (e.g., `.flex-sm-column`).

<!-- Boosted mod : design callout -->
{{< ods-incompatibility-alert >}}
These **vertical** component variants should not be used because they do not respect the Orange Design System specifications. Indeed, nav items should be displayed horizontally.

Instead, please consider using our Boosted [Tabs light]({{< docsref "/components/navs-tabs#tabs-light" >}}) variant. You can also refer to [Navigation](https://system.design.orange.com/0c1af118d/p/44331c-navigation/b/9105e6) guidelines on the Orange Design System website.
louismaximepiton marked this conversation as resolved.
Show resolved Hide resolved
{{< /ods-incompatibility-alert >}}

{{< example >}}
<ul class="nav flex-column">
<li class="nav-item">
Expand Down Expand Up @@ -255,6 +282,12 @@ This variant should not be used because it is a button component in the Orange D

Force your `.nav`'s contents to extend the full available width one of two modifier classes. To proportionately fill all available space with your `.nav-item`s, use `.nav-fill`. Notice that all horizontal space is occupied, but not every nav item has the same width.

{{< ods-incompatibility-alert >}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel like the concepts behind will be lost. Same below.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once again, the problem is not the technical part, but the look of the component used to illustrate this technical part...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should mention it or maybe change the examples look but I'm not sure this is possible...

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⁉️ TODO: Review this whole page with the designers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linked to my previous comment. If this is only a design reason but that the feature can be used it should be clearly explained.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. From the info I have so far, the problem is the fact that the design should be buttons and not links.
TBH, it would be good to re-clarify the reasons of not using with the design.
Meanwhile, what about:

These link variants, which are just examples illustrating the use of the fill and justify utilities, should not be used because they do not respect the Orange Design System specifications. Indeed, they should be button components.

With more details, it might be useful to add a "refer to our Boosted ..." and/or "refer to the xx guidelines the ODS website"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use links on the whole page here even for https://deploy-preview-1614--boosted.netlify.app/docs/5.2/components/navs-tabs/#nested-tabs. Imo, it's not the main issue here since it's a design issue + no need to redirect to tabs light imo

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me try to clarify:

  • Here, we have nav with links <a> that have the look of buttons <button>. Here, it's not possible to have that. If we want to have components that have the look of buttons, then in the code they should be <button> html tags.
  • Now besides the combination "html tag/expected design", the only look that is ok for such components is the one of the tabs light.

Would this version be more satisfying ?
These link variants, which are just examples illustrating the use of the fill and justify utilities, should not be used because they do not respect the Orange Design System specifications. Indeed, nav tabs and html tags should not look like buttons.
Instead, please consider using our Boosted Tabs light variant. You can also refer to Navigation guidelines on the Orange Design System website.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, we have a nav with links that have the look of buttons . Here, it's not possible to have that. If we want to have components that have the look of buttons, then in the code they should be html tags.

I strongly disagree with the fact that <a> shouldn't look like buttons. Since many call to action are presented as buttons but are truly links. I think it strongly depends on the context and the associated action. IMO, the actual behavior is fine.

Otherwise, many many and many designs will have to change as well.

IMO, if this is accepted by design:
image

instead of:
image

We might consider using .nav-underline instead of .nav-pill to present the remaining doc. We should keep a callout only if the design is against a specific feature. Any thoughts @julien-deramond ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just done it.

These **link** variants, which are just **examples illustrating the use of the fill and justify utilities**, should not be used because they do not respect the Orange Design System specifications. Indeed, they should be `<button>` components and not `<li><a></a></li>` components.

Instead, please consider using our Boosted [Tabs light]({{< docsref "/components/navs-tabs#tabs-light" >}}) variant. You can also refer to [Navigation](https://system.design.orange.com/0c1af118d/p/44331c-navigation/b/9105e6) guidelines on the Orange Design System website.
{{< /ods-incompatibility-alert >}}

{{< example >}}
<ul class="nav nav-pills nav-fill">
<li class="nav-item">
Expand Down Expand Up @@ -317,6 +350,12 @@ Similar to the `.nav-fill` example using a `<nav>`-based navigation.

If you need responsive nav variations, consider using a series of [flexbox utilities]({{< docsref "/utilities/flex" >}}). While more verbose, these utilities offer greater customization across responsive breakpoints. In the example below, our nav will be stacked on the lowest breakpoint, then adapt to a horizontal layout that fills the available width starting from the small breakpoint.

{{< ods-incompatibility-alert >}}
This **link** variant, which is just an **example illustrating the use of the flexbox utilities**, should not be used because it does not respect the Orange Design System specifications. Indeed, they should be `<button>` components and not `<li><a></a></li>` components.

Instead, please consider using our Boosted [Tabs light]({{< docsref "/components/navs-tabs#tabs-light" >}}) variant. You can also refer to [Navigation](https://system.design.orange.com/0c1af118d/p/44331c-navigation/b/9105e6) guidelines on the Orange Design System website.
{{< /ods-incompatibility-alert >}}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as above (just not to forget)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⁉️ TODO: Review this whole page with the designers.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same answer as above:
Here, we have a nav with links that have the look of buttons . Here, it's not possible to have that. If we want to have components that have the look of buttons, then in the code they should be html tags.
Now besides the combination "html tag/expected design", the only look that is ok for such components is the one of the tabs light.

Would this version be more satisfying ?
These link variants, which are just examples illustrating the use of the fill and justify utilities, should not be used because they do not respect the Orange Design System specifications. Indeed, nav tabs and <a> html tags should not look like buttons.
Instead, please consider using our Boosted Tabs light variant. You can also refer to Navigation guidelines on the Orange Design System website.

{{< example >}}
<nav class="nav nav-pills flex-column flex-sm-row">
<a class="flex-sm-fill text-sm-center nav-link active" aria-current="page" href="#">Active</a>
Expand All @@ -338,6 +377,13 @@ Add dropdown menus with a little extra HTML and the [dropdowns JavaScript plugin

### Tabs with dropdowns

<!-- Boosted mod : design callout -->
{{< ods-incompatibility-alert >}}
This component variant with a **dropdown menu not placed at the very end of the line** should not be used because it does not respect the Orange Design System specifications.

Please refer to [Navigation](https://system.design.orange.com/0c1af118d/p/44331c-navigation/b/9105e6) guidelines on the Orange Design System website.
{{< /ods-incompatibility-alert >}}
isabellechanclou marked this conversation as resolved.
Show resolved Hide resolved

{{< example >}}
<ul class="nav nav-tabs">
<li class="nav-item">
Expand Down
6 changes: 6 additions & 0 deletions site/content/docs/5.2/components/progress.md
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,12 @@ Please refer to the [Progress indicators](https://system.design.orange.com/0c1af

Include multiple progress bars in a progress component if you need.

{{< ods-incompatibility-alert >}}
This variant should not be used because it does not respect the Orange Design System specifications.
isabellechanclou marked this conversation as resolved.
Show resolved Hide resolved

Please refer to the [Progress indicators](https://system.design.orange.com/0c1af118d/p/45093c-progress-indicators/b/2875f1) guidelines on the Orange Design System website.
{{< /ods-incompatibility-alert >}}

{{< example >}}
<div class="progress">
<div class="progress-bar" role="progressbar" aria-label="Segment one" style="width: 15%" aria-valuenow="15" aria-valuemin="0" aria-valuemax="100"></div>
Expand Down
6 changes: 6 additions & 0 deletions site/content/docs/5.2/components/tooltips.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,12 @@ Hover over the links below to see tooltips:

### Custom tooltips

{{< ods-incompatibility-alert >}}
This **customized** variant should not be used because it does not respect the Orange Design System specifications. More generally, customizing tooltip CSS might lead to mismatch the Orange Design System.

Please refer to the [Tooltip](https://system.design.orange.com/0c1af118d/p/932946-tooltip/b/417f3e) guidelines on the Orange Design System website.
louismaximepiton marked this conversation as resolved.
Show resolved Hide resolved
{{< /ods-incompatibility-alert >}}

{{< added-in "5.2.0" >}}

{{< ods-incompatibility-alert >}}
Expand Down
6 changes: 6 additions & 0 deletions site/content/docs/5.2/forms/checks-radios.md
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,12 @@ Create button-like checkboxes and radio buttons by using `.btn` styles rather th

### Checkbox toggle buttons

{{< ods-incompatibility-alert >}}
These **checkbox toggle button** variants should not be used because they do not respect the Orange Design System specifications. Indeed, from the Orange Design System point of view a checkbox should always look like a checkbox component.

Instead, consider using our Boosted [Checks]({{< docsref "/forms/checks-radios#checks" >}}), [Radios]({{< docsref "/forms/checks-radios#radios" >}}) or [Radio toggle buttons]({{< docsref "/forms/checks-radios#radio-toggle-buttons" >}}) components.
{{< /ods-incompatibility-alert >}}

{{< example >}}
<input type="checkbox" class="btn-check" id="btn-check" autocomplete="off">
<label class="btn btn-primary" for="btn-check">Single toggle</label>
Expand Down
7 changes: 7 additions & 0 deletions site/content/docs/5.2/forms/form-control.md
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,13 @@ Add the `readonly` boolean attribute on an input to prevent modification of the

If you want to have `<input readonly>` elements in your form styled as plain text, replace `.form-control` with `.form-control-plaintext` to remove the default form field styling and preserve the correct `margin` and `padding`.

{{< ods-incompatibility-alert >}}
This form variant with an **horizontal layout** (i.e. labels not above the input fields) should not be used because it does no respect the Orange Design System specifications.
isabellechanclou marked this conversation as resolved.
Show resolved Hide resolved

Please refer to the [Forms](https://system.design.orange.com/0c1af118d/p/88ab5b-forms/b/599459) guidelines and to the [Pages](https://system.design.orange.com/0c1af118d/p/20500e-form/b/16bb53) form examples on the Orange Design System website.

{{< /ods-incompatibility-alert >}}

{{< example >}}
<div class="mb-3 row">
<label for="staticEmail" class="col-sm-2 col-form-label">Email</label>
Expand Down
19 changes: 19 additions & 0 deletions site/content/docs/5.2/forms/input-group.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,12 @@ Add the relative form sizing classes to the `.input-group` itself and contents w

**Sizing on the individual input group elements isn't supported.**

{{< ods-incompatibility-alert >}}
These 3 form variants, with an **horizontal layout** (i.e. labels not above the input fields), and the **small** one with a height of 28px, should not be used because they do not respect the Orange Design System specifications.
louismaximepiton marked this conversation as resolved.
Show resolved Hide resolved

Please refer to the [Forms](https://system.design.orange.com/0c1af118d/p/88ab5b-forms/b/599459) guidelines and to the [Pages](https://system.design.orange.com/0c1af118d/p/20500e-form/b/16bb53) form examples on the Orange Design System website.
{{< /ods-incompatibility-alert >}}

{{< example >}}
<div class="input-group input-group-sm mb-3">
<span class="input-group-text" id="inputGroup-sizing-sm">Small</span>
Expand Down Expand Up @@ -275,6 +281,13 @@ Input groups include support for custom selects and custom file inputs. Browser

### Custom select

{{< ods-incompatibility-alert >}}
These **3 first** form variants should not be used because they do not respect the Orange Design System specifications. The **2 first** form variants should have a vertical layout (i.e., having their label above the input field. The **third** form variant should be split in 2 elements (a button and a dropdown) which should be presented in a more logical way : the dropdown first and then the button.
isabellechanclou marked this conversation as resolved.
Show resolved Hide resolved

Please refer to the [Forms](https://system.design.orange.com/0c1af118d/p/88ab5b-forms/b/599459) guidelines and to the [Pages](https://system.design.orange.com/0c1af118d/p/20500e-form/b/16bb53) form examples on the Orange Design System website.

{{< /ods-incompatibility-alert >}}

{{< example >}}
<div class="input-group mb-3">
<label class="input-group-text" for="inputGroupSelect01">Options</label>
Expand Down Expand Up @@ -319,6 +332,12 @@ Input groups include support for custom selects and custom file inputs. Browser

### Custom file input

{{< ods-incompatibility-alert >}}
These form variants should not be used because they do not respect the Orange Design System specifications.

Please refer to the [Forms](https://system.design.orange.com/0c1af118d/p/88ab5b-forms/b/599459) guidelines and to the [Pages](https://system.design.orange.com/0c1af118d/p/20500e-form/b/16bb53) form examples on the Orange Design System website.
{{< /ods-incompatibility-alert >}}

{{< example >}}
<div class="input-group mb-3">
<label for="inputGroupFile01" class="input-group-text">Upload</label>
Expand Down