Fix missing attribute in global header standard example #1662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
LGTM. Could you please update https://deploy-preview-1662--boosted.netlify.app/docs/5.2/components/orange-navbar/#navigation-under where there's a missing aria-current="page" as well.
|
Same for right part of supra bar in https://deploy-preview-1662--boosted.netlify.app/docs/5.2/components/orange-navbar/#responsive-behavior ! Missing |
MewenLeHo
force-pushed
the
main-mlh-fix-missing-attribute-in-header-example
branch
from
79be1dd
to
57b675f
Compare
MewenLeHo
force-pushed
the
main-mlh-fix-missing-attribute-in-header-example
branch
from
2d3d0a4
to
f053a5f
Compare
louismaximepiton
approved these changes
Nov 28, 2022
julien-deramond
approved these changes
Nov 28, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
julien-deramond
deleted the
main-mlh-fix-missing-attribute-in-header-example
branch
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
The attribute
aria-current="page"was used in the code example:but was missing from the associated HTML code:
Description
Add missing attribute.
Types of change
Live previews
Checklist
npm run lint)