Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add padding to accordion content #1727

Merged
merged 13 commits into from Dec 30, 2022
Merged

Add padding to accordion content #1727

merged 13 commits into from Dec 30, 2022

Conversation

MewenLeHo
Copy link
Contributor

@MewenLeHo MewenLeHo commented Dec 21, 2022 •
edited

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Description

Add a little bit of padding to accordion content.

Motivation & Context

2 goals: compliance with design guidelines and prevent incoming focus of accordion title to overlap accordion content.

Types of change

  • Bug fix (non-breaking which fixes an issues)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with responsive display

Development

  • My change follows the developer guide
  • (NA) I have added JavaScript unit tests to cover my changes

Documentation

  • (NA) My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • (NA) My change introduces changes to the migration guide
  • (NA) My new component is added in Storybook
  • (NA) My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • (NA) A11y review

After the merge

@MewenLeHo MewenLeHo marked this pull request as draft December 21, 2022 08:37
@netlify
Copy link

netlify bot commented Dec 21, 2022 •
edited

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 7d40650
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/63aed5a57f8204000890a79b
😎 Deploy Preview https://deploy-preview-1727--boosted.netlify.app/docs/5.2/migration
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@MewenLeHo MewenLeHo marked this pull request as ready for review December 21, 2022 08:56
@MewenLeHo MewenLeHo changed the title Add some padding Add padding to accordion content Dec 21, 2022
@julien-deramond julien-deramond added this to In progress in v5.2.3 Dec 21, 2022
louismaximepiton
louismaximepiton requested changes Dec 21, 2022
View reviewed changes
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few changes before approving !

scss/_accordion.scss Outdated Show resolved Hide resolved
scss/_accordion.scss Outdated Show resolved Hide resolved
@louismaximepiton louismaximepiton mentioned this pull request Dec 22, 2022
Merged
@louismaximepiton louismaximepiton mentioned this pull request Dec 22, 2022
Open
6 tasks
@MewenLeHo

This comment was marked as outdated.

Sign in to view
@MewenLeHo

This comment was marked as outdated.

Sign in to view
louismaximepiton
louismaximepiton requested changes Dec 23, 2022
View reviewed changes
scss/_accordion.scss Outdated Show resolved Hide resolved
scss/_variables.scss Show resolved Hide resolved
scss/_variables.scss Show resolved Hide resolved
louismaximepiton
louismaximepiton approved these changes Dec 29, 2022
View reviewed changes
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sonarcloud
Copy link

sonarcloud bot commented Dec 30, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

julien-deramond
julien-deramond approved these changes Dec 30, 2022
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@julien-deramond julien-deramond merged commit 20d8f0c into main Dec 30, 2022
v5.2.3 automation moved this from In progress to Done Dec 30, 2022
@julien-deramond julien-deramond deleted the main-mlh-fix-padding-accordion-content branch December 30, 2022 12:15
@julien-deramond julien-deramond mentioned this pull request Dec 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

@louismaximepiton louismaximepiton louismaximepiton approved these changes

Assignees
No one assigned
Labels
css fix upcoming design review v5
Projects
No open projects
v5.2.3
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MewenLeHo @julien-deramond @louismaximepiton