-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add story button component #1816
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
e7ad023
to
031f163
Compare
I know this is a draft PR but just a question here being off for few weeks. There's only one size? What about smaller screens? |
There is indeed no small size variant in the UI Kit V5 at the moment. |
2f89909
to
e01820e
Compare
a11y ok |
Reminder: don't forget to add some lines to introduce this new type of button in documentation. But we need to figure out first what it can be used for. |
After last specs meeting with the designers, we agreed that:
|
Kudos, SonarCloud Quality Gate passed!
|
…enSource/Orange-Boosted-Bootstrap into main-mlh-story-buttons
Kudos, SonarCloud Quality Gate passed!
|
Specifications are not complete. I'm closing this PR and mentioning it as a reference in the corresponding issue so that we can maybe start from it when it will be ready to develop. Please don't delete the branch. |
Related issues
Part of #1761
Description
Add story button componenent
Motivation & Context
New component based on UI Kit v5.
Types of change
Live previews
https://deploy-preview-1816--boosted.netlify.app/docs/5.3/components/buttons/#story-button
and don't forget: https://deploy-preview-1816--boosted.netlify.app/docs/5.3/components/buttons/#dark-variant
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)
After the merge