Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add story button component #1816

Closed
wants to merge 28 commits into from
Closed

Add story button component #1816

wants to merge 28 commits into from

Conversation

MewenLeHo
Copy link
Contributor

@MewenLeHo MewenLeHo commented Feb 6, 2023

Related issues

Part of #1761

Description

Add story button componenent

Motivation & Context

New component based on UI Kit v5.

Types of change

  • New feature (non-breaking change which adds functionality)

Live previews

https://deploy-preview-1816--boosted.netlify.app/docs/5.3/components/buttons/#story-button
and don't forget: https://deploy-preview-1816--boosted.netlify.app/docs/5.3/components/buttons/#dark-variant

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with responsive display

Development

  • My change follows the developer guide
  • (NA) I have added JavaScript unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • My change introduces changes to the migration guide
  • My new component is added in Storybook
  • My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

@netlify
Copy link

netlify bot commented Feb 6, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit da06f4c
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/646b576ebe2a1f0008ed1c06
😎 Deploy Preview https://deploy-preview-1816--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@MewenLeHo MewenLeHo marked this pull request as draft February 6, 2023 13:25
@julien-deramond
Copy link
Member

I know this is a draft PR but just a question here being off for few weeks. There's only one size? What about smaller screens?

@MewenLeHo
Copy link
Contributor Author

MewenLeHo commented Feb 7, 2023

I know this is a draft PR but just a question here being off for few weeks. There's only one size? What about smaller screens?

There is indeed no small size variant in the UI Kit V5 at the moment.
I asked for it at the last specs meeting and designers answered that the thumbnail displayed in the link needs to be big enough to be seen so they don't plan to make a smaller version.

@Aniort Aniort self-assigned this Feb 13, 2023
@Aniort
Copy link
Contributor

Aniort commented Feb 13, 2023

a11y ok

@MewenLeHo MewenLeHo marked this pull request as ready for review February 14, 2023 08:06
@MewenLeHo
Copy link
Contributor Author

Reminder: don't forget to add some lines to introduce this new type of button in documentation. But we need to figure out first what it can be used for.

@MewenLeHo
Copy link
Contributor Author

After last specs meeting with the designers, we agreed that:

  • a small size variant will be needed
  • we need to define exactly the UX part of this component
  • we must define if we keep it like it is or create a 'navigation' section in the documentation for story (and social ?) button(s) or even if it should be a new component by itself.

@sonarcloud
Copy link

sonarcloud bot commented Feb 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@B3nz01d B3nz01d added this to Dev Review in 🟣 PR Board (Draft) Mar 29, 2023
@MewenLeHo MewenLeHo marked this pull request as draft April 26, 2023 13:55
@sonarcloud
Copy link

sonarcloud bot commented May 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julien-deramond
Copy link
Member

Specifications are not complete. I'm closing this PR and mentioning it as a reference in the corresponding issue so that we can maybe start from it when it will be ready to develop. Please don't delete the branch.

@julien-deramond julien-deramond deleted the main-mlh-story-buttons branch July 17, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
🟣 PR Board (Draft)
Need Dev Review
Development

Successfully merging this pull request may close these issues.

None yet

3 participants