-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore merge 9th of February #1828
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
New batch of commits ready for your review @louismaximepiton 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Haven't checked in details all the Scss tests since they all pass.
- Since twbs/bootstrap@6295d3b, we can remove a Boosted mod in
site\assets\scss\_masthead.scss
+ is that fine to not have the_buttons.scss
file (even empty) ?
Sure me neither in details but let's start with it. We just need to think now that they exist. I've added something in our PR template to not to forget: 2e47087.
I don't have a strong opinion on whether we need an empty |
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 😄
twbs/bootstrap@9bd7228: nothing to do since we don't have any Dropdowns exampletwbs/bootstrap@bae3260: nothing to do here sincesocket.io-parser
deps has already been bumped by Dependabottwbs/bootstrap@492187d: nothing to do since we don't have any Cheatsheet exampletwbs/bootstrap@21956ee: nothing to do since we don't have such image in our homepagetwbs/bootstrap@406ab2a: nothing to do since score card is removed right aftertwbs/bootstrap@9757634: nothing to do since we didn't include score cards in previous commits