Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore merge 9th of February #1828

Merged
merged 20 commits into from
Feb 13, 2023
Merged

Chore merge 9th of February #1828

merged 20 commits into from
Feb 13, 2023

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Feb 9, 2023

@julien-deramond julien-deramond added chore merge Sync with Bootstrap skip:ci labels Feb 9, 2023
@netlify
Copy link

netlify bot commented Feb 9, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 73c3507
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/63e9eeb6addf5500082d4106
😎 Deploy Preview https://deploy-preview-1828--boosted.netlify.app/docs/5.3/migration
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@julien-deramond
Copy link
Member Author

New batch of commits ready for your review @louismaximepiton 🙏

@julien-deramond julien-deramond marked this pull request as ready for review February 9, 2023 11:52
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Haven't checked in details all the Scss tests since they all pass.
  • Since twbs/bootstrap@6295d3b, we can remove a Boosted mod in site\assets\scss\_masthead.scss + is that fine to not have the _buttons.scss file (even empty) ?

scss/tests/mixins/_utilities.test.scss Show resolved Hide resolved
scss/tests/utilities/_api.test.scss Show resolved Hide resolved
site/assets/scss/_search.scss Show resolved Hide resolved
site/content/docs/5.3/components/navbar.md Show resolved Hide resolved
site/content/docs/5.3/migration.md Outdated Show resolved Hide resolved
@julien-deramond
Copy link
Member Author

Haven't checked in details all the Scss tests since they all pass.

Sure me neither in details but let's start with it. We just need to think now that they exist. I've added something in our PR template to not to forget: 2e47087.

Since twbs/bootstrap@6295d3b, we can remove a Boosted mod in site\assets\scss_masthead.scss + is that fine to not have the _buttons.scss file (even empty) ?

I don't have a strong opinion on whether we need an empty _buttons.scss or not. If you have one, please tell me. Otherwise, I'm going to let it as is.
Regarding the removing of the Boosted mod, good catch, done via 045dd8b

@sonarcloud
Copy link

sonarcloud bot commented Feb 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😄

@julien-deramond julien-deramond mentioned this pull request Feb 13, 2023
19 tasks
@julien-deramond julien-deramond merged commit f48e896 into main Feb 13, 2023
@julien-deramond julien-deramond deleted the main-jd-chore-merge-9-feb branch February 13, 2023 08:50
@julien-deramond julien-deramond mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore merge Sync with Bootstrap
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants