Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode: Dropdowns #2292

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

hannahiss
Copy link
Member

@hannahiss hannahiss commented Oct 9, 2023

Description

Dropdowns in dark mode, by using existing Sass vars :

Sass var Previous value New value
$dropdown-link-hover-bg $gray-500 var(--#{$prefix}border-color-translucent) ⚠️ strange use of this variable
$dropdown-link-active-color color-contrast($component-active-color) var(--#{$prefix}highlight-color)
$dropdown-link-active-bg $component-active-color var(--#{$prefix}highlight-bg)
$dropdown-link-disabled-color $gray-500 var(--#{$prefix}disabled-color)
$dropdown-header-color $black var(--#{$prefix}body-color)

NB: added and completed Boosted mod comments

Links

@hannahiss hannahiss changed the base branch from main to main-jd-dark-mode October 9, 2023 15:12
@netlify
Copy link

netlify bot commented Oct 9, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 7ca68cf
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/65250fc95af1340008f6810d
😎 Deploy Preview https://deploy-preview-2292--boosted.netlify.app/docs/5.3/components/dropdowns
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@hannahiss hannahiss changed the title Main his dark mode dropdowns Dark mode: Dropdowns Oct 9, 2023
@hannahiss hannahiss marked this pull request as ready for review October 9, 2023 15:31
@hannahiss hannahiss added the color mode Temporary label to highlight color mode issues label Oct 9, 2023
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the comment above is tackled, I'll be fine

@julien-deramond julien-deramond merged commit 2401082 into main-jd-dark-mode Oct 10, 2023
11 of 12 checks passed
@julien-deramond julien-deramond deleted the main-his-dark-mode-dropdowns branch October 10, 2023 08:48
@julien-deramond julien-deramond mentioned this pull request Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
color mode Temporary label to highlight color mode issues
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants