Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode: Close button #2317

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Dark mode: Close button #2317

merged 2 commits into from
Oct 26, 2023

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Oct 17, 2023 •
edited by boosted-bot
Loading

Description

Close button in dark mode, by using existing Sass vars :

Sass var Previous value New value
$btn-close-active-color $primary var(--#{$prefix}link-hover-color)
$btn-close-active-border-color $gray-500 var(--#{$prefix}border-color-translucent)
$btn-close-disabled-color $gray-500 var(--#{$prefix}disabled-color)

Links

@louismaximepiton louismaximepiton added the color mode Temporary label to highlight color mode issues label Oct 17, 2023
@netlify
Copy link

netlify bot commented Oct 17, 2023 •
edited
Loading

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 2e75908
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6539f43bddcdb90008dd12a3
😎 Deploy Preview https://deploy-preview-2317--boosted.netlify.app/docs/5.3/dark-mode
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

julien-deramond
julien-deramond approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've just added the eco-design variants too in the dark mode page via 2e75908

@julien-deramond julien-deramond merged commit bbf1afd into main-jd-dark-mode Oct 26, 2023
13 of 14 checks passed
@julien-deramond julien-deramond deleted the main-lmp-close-btn-dark branch October 26, 2023 05:09
@julien-deramond julien-deramond mentioned this pull request Oct 26, 2023
Merged
julien-deramond added a commit that referenced this pull request Oct 26, 2023
@louismaximepiton @julien-deramond
Dark mode: Close button (#2317)
fc169fa 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Oct 31, 2023
@louismaximepiton @julien-deramond
Dark mode: Close button (#2317)
1ebcff3 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 3, 2023
@louismaximepiton @julien-deramond
Dark mode: Close button (#2317)
6737809 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 3, 2023
@louismaximepiton @julien-deramond
Dark mode: Close button (#2317)
906c80e 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 3, 2023
@louismaximepiton @julien-deramond
Dark mode: Close button (#2317)
8c9daea 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 6, 2023
@louismaximepiton @julien-deramond
Dark mode: Close button (#2317)
69dcfe4 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 7, 2023
@louismaximepiton @julien-deramond
Dark mode: Close button (#2317)
ff34397 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 8, 2023
@louismaximepiton @julien-deramond
Dark mode: Close button (#2317)
155df51 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 10, 2023
@louismaximepiton @julien-deramond
Dark mode: Close button (#2317)
322de33 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 13, 2023
@louismaximepiton @julien-deramond
Dark mode: Close button (#2317)
0575d52 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 15, 2023
@louismaximepiton @julien-deramond
Dark mode: Close button (#2317)
6517925 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 27, 2023
@louismaximepiton @julien-deramond
Dark mode: Close button (#2317)
d34ae1f 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 27, 2023
@louismaximepiton @julien-deramond
Dark mode: Close button (#2317)
2335cc1 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 27, 2023
@louismaximepiton @julien-deramond
Dark mode: Close button (#2317)
0ae3685 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 29, 2023
@louismaximepiton @julien-deramond
Dark mode: Close button (#2317)
5ef72e9 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Nov 30, 2023
@louismaximepiton @julien-deramond
Dark mode: Close button (#2317)
c94c042 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 1, 2023
@louismaximepiton @julien-deramond
Dark mode: Close button (#2317)
c697cbb 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 4, 2023
@louismaximepiton @julien-deramond
Dark mode: Close button (#2317)
f727cc9 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 8, 2023
@louismaximepiton @julien-deramond
Dark mode: Close button (#2317)
e828954 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 15, 2023
@louismaximepiton @julien-deramond
Dark mode: Close button (#2317)
504c89c 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 18, 2023
@louismaximepiton @julien-deramond
Dark mode: Close button (#2317)
39f628c 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 21, 2023
@louismaximepiton @julien-deramond
Dark mode: Close button (#2317)
385a0a8 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 26, 2023
@louismaximepiton @julien-deramond
Dark mode: Close button (#2317)
7782312 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Dec 27, 2023
@louismaximepiton @julien-deramond
Dark mode: Close button (#2317)
a81f082 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
julien-deramond added a commit that referenced this pull request Jan 2, 2024
@louismaximepiton @julien-deramond
Dark mode: Close button (#2317)
142b9e5 
Co-authored-by: Julien Déramond <julien.deramond@orange.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees
No one assigned
Labels
color mode Temporary label to highlight color mode issues
Projects
🟣 [Orange-Boosted-Bootstrap] PRs Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@louismaximepiton @julien-deramond