Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar: Handle in a proper way our dropdowns inside documentation navbar #2432

Merged
merged 6 commits into from
Dec 27, 2023

Conversation

louismaximepiton
Copy link
Member

Description

We had an issue when we wanted to explore an overcharged navbar with some dropdowns for example.
We implement a little different behavior than Bootstrap since we have much complex navbars.
Reorganize docs navbar to have something more branded navbar (more spacing).

Live previews

@louismaximepiton louismaximepiton added v5 docs Improvements or additions to documentation fix css labels Dec 20, 2023
Copy link

netlify bot commented Dec 20, 2023

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit a86b6d5
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/658bdaf44f0b7c00080bd39e
😎 Deploy Preview https://deploy-preview-2432--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@louismaximepiton louismaximepiton marked this pull request as draft December 21, 2023 08:20
scss/_navbar.scss Outdated Show resolved Hide resolved
@louismaximepiton louismaximepiton changed the base branch from main to main-lmp-theme-switcher-control December 26, 2023 09:58
@louismaximepiton louismaximepiton changed the base branch from main-lmp-theme-switcher-control to main December 26, 2023 10:03
@louismaximepiton louismaximepiton marked this pull request as ready for review December 26, 2023 10:10
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we can't do better right now.

Let's create an issue too regarding the fact that we had to add a .bd-header instead of using .bd-navbar as it is done on the Bootstrap side.

@julien-deramond julien-deramond merged commit f9c77d7 into main Dec 27, 2023
14 checks passed
@julien-deramond julien-deramond deleted the main-lmp-navbar-fix-mobile-scroll branch December 27, 2023 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
css docs Improvements or additions to documentation fix v5
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants