Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(merge main): patched commit → 24f749c #2529

Merged
merged 9 commits into from
Mar 29, 2024
Merged

chore(merge main): patched commit → 24f749c #2529

merged 9 commits into from
Mar 29, 2024

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Mar 26, 2024 •
edited
Loading

Non-regression testing

  • Cookies banner (when loading the doc or manually)
  • Storybook (accordions, tooltips)
  • StackBlitz (most complex and weird examples)
  • Documentation search
  • Documentation copy/pasting
  • Documentation color palette copy/pasting
  • Do exactly the same tests as above but from the _site directory after running npm run docs

@julien-deramond julien-deramond added v5 chore merge Sync with Bootstrap labels Mar 26, 2024
@netlify Netlify
Copy link

netlify bot commented Mar 26, 2024 •
edited
Loading

✅ Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 6459d95
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/66056b39a599c80008aa5787
😎 Deploy Preview https://deploy-preview-2529--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond force-pushed the main-jd-chore-merge-from-24f749c branch 2 times, most recently from 529136f to 4610d6c Compare March 26, 2024 15:00
@julien-deramond julien-deramond force-pushed the main-jd-chore-merge-from-24f749c branch 2 times, most recently from f78fd28 to e0a7a7a Compare March 26, 2024 15:15
@julien-deramond julien-deramond force-pushed the main-jd-chore-merge-from-24f749c branch from e0a7a7a to 1cbf84c Compare March 26, 2024 15:17
@julien-deramond julien-deramond marked this pull request as ready for review March 28, 2024 13:08
louismaximepiton
louismaximepiton approved these changes Mar 29, 2024
View reviewed changes
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels a bit weird to still have js/snippets.js file but let's try to tackle it on Bootstrap side directly. Good job 😀

@julien-deramond julien-deramond merged commit aee712a into main Mar 29, 2024
17 checks passed
@julien-deramond julien-deramond deleted the main-jd-chore-merge-from-24f749c branch March 29, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@louismaximepiton louismaximepiton louismaximepiton approved these changes

Assignees
No one assigned
Labels
chore merge Sync with Bootstrap v5
Projects
🟣 [Orange-Boosted-Bootstrap] PRs Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@julien-deramond @louismaximepiton