Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps: Group dependabot PRs for Storybook #2538

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Apr 3, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

NA

Description

Add a group to dependabot.yml

Motivation & Context

Ease of maintenance

Types of change

  • New feature (non-breaking change which adds functionality)

Live previews

NA

Checklist

Contribution

Accessibility

  • (NA) My change follows accessibility good practices; I have at least run axe

Design

  • (NA) My change respects the design guidelines defined in Orange Design System
  • (NA) My change is compatible with a responsive display

Development

  • (NA) My change follows the developer guide
  • (NA) I have added JavaScript unit tests to cover my changes
  • (NA) I have added SCSS unit tests to cover my changes

Documentation

  • (NA) My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • (NA) My change introduces changes to the migration guide
  • (NA) My new component is well displayed in Storybook
  • (NA) My new component is compatible with RTL
  • (NA) Manually run BrowserStack tests
  • (NA) Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

@louismaximepiton louismaximepiton added v5 dependencies Pull requests that update a dependency file enhancement labels Apr 3, 2024
Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit f38498e
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/660d08f54a14010008014536
😎 Deploy Preview https://deploy-preview-2538--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @louismaximepiton
Let's try it!

@julien-deramond julien-deramond merged commit 0ae936a into main Apr 3, 2024
19 checks passed
@julien-deramond julien-deramond deleted the main-lmp-group-storybook-deps branch April 3, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement v5
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants