-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Add <details><summary>
to hide design callouts
#2548
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for boosted ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wording should be reviewed sometimes.
The details summary should mention the incompatibility with ODS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing some details on pages in utilities, like colors, links, ....
Note: Please transform
- [ ]
into- (NA)
in the description when things are not applicableRelated issues
NA
Description
Added small CSS to handle these hidden parts.
Some design callouts weren't hidden for understanding of the doc (navs&tabs, navbar, introduction, badge and so on).
Summary used in the doc for the details summary:
See Bootstrap example(s) incompatible with Orange Design System
Several questions to answer before merging this:
Motivation & Context
Following the refactoring of buttons and dropdowns.
Avoid polluting the user experience.
Types of change
Live previews
Checklist
Contribution
Accessibility
Design
Development
Documentation
Checklist (for Core Team only)
After the merge