Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS: Change the base dark mode red color palette #2549

Merged
merged 3 commits into from
Apr 30, 2024

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Apr 23, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

NA

Description

Changed the base red color for dark mode.
Checked:

  • CSS variables
  • Form validations
  • Alerts
  • Badge
  • Buttons
  • Dropdowns
  • Progress
  • Color&Background
  • Colored links
  • Focus ring
  • Background
  • Border
  • Colors
  • Icons

From what I could see and test, our colors seem to be properly wired

Motivation & Context

The red color has changed on the design side in their last release of the kit.

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with a responsive display

Development

  • My change follows the developer guide
  • I have added JavaScript unit tests to cover my changes
  • I have added SCSS unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • My change introduces changes to the migration guide
  • My new component is well displayed in Storybook
  • My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit fea0ecc
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/662bb00b51684600083070de
😎 Deploy Preview https://deploy-preview-2549--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the patch. I'm just waiting for a design confirmation, then we can merge it :shipit:

@julien-deramond julien-deramond merged commit cfedfa0 into main Apr 30, 2024
14 checks passed
@julien-deramond julien-deramond deleted the main-lmp-change-dark-mode-danger-color branch April 30, 2024 05:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants