Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix documentation for dark red change #2567

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

louismaximepiton
Copy link
Member

@louismaximepiton louismaximepiton commented Jun 5, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

NA

Description

Apply the new hex color to the documentation.
Fix the migration guide.

Motivation & Context

For people to use and see the right color.

Types of change

  • Bug fix (non-breaking which fixes an issue)

Live previews

Checklist

Contribution

Accessibility

  • My change follows accessibility good practices; I have at least run axe

Design

  • My change respects the design guidelines defined in Orange Design System
  • My change is compatible with a responsive display

Development

  • My change follows the developer guide
  • I have added JavaScript unit tests to cover my changes
  • I have added SCSS unit tests to cover my changes

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • My change introduces changes to the migration guide
  • My new component is well displayed in Storybook
  • My new component is compatible with RTL
  • Manually run BrowserStack tests
  • Manually test browser compatibility with BrowserStack (Chrome >= 60, Firefox >= 60 (+ ESR), Edge, Safari >= 12, iOS Safari, Chrome & Firefox on Android)
  • Code review
  • Design review
  • A11y review

After the merge

@louismaximepiton louismaximepiton added v5 docs Improvements or additions to documentation fix labels Jun 5, 2024
Copy link

netlify bot commented Jun 5, 2024

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit b3d6985
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/66602d2993bb4c0008cc9814
😎 Deploy Preview https://deploy-preview-2567--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@julien-deramond julien-deramond merged commit a5b723c into main Jun 5, 2024
19 checks passed
@julien-deramond julien-deramond deleted the main-lmp-fix-docs-after-changing-red-color branch June 5, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation fix v5
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants