feat(lineLength): Add class to limit line length #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: louismaximepiton <louismaxime.piton@orange.com>
julien-deramond
requested changes
Nov 15, 2021
Signed-off-by: louismaximepiton <louismaxime.piton@orange.com>
Signed-off-by: louismaximepiton <louismaxime.piton@orange.com>
julien-deramond
approved these changes
Nov 22, 2021
There was a problem hiding this comment.
Sounds good to me. @Lausselloic, do you want to look at it?
Lausselloic
approved these changes
Nov 22, 2021
Closed
ffoodd
reviewed
Nov 22, 2021
|
|
||
| ### Maximum line length | ||
|
|
||
| When writing a paragraph, it is commonly admitted that a line should have 80 characters as a maximum. This phenomenon is carefully explained in the [C20 website: Using relative measurements to set column widths](https://www.w3.org/TR/2016/NOTE-WCAG20-TECHS-20161007/C20). |
There was a problem hiding this comment.
C20 is a WCAG technique, not a website. Maybe ask for some EASE review for such contents?
| @@ -101,6 +101,17 @@ Change the line height with `.lh-*` utilities. | |||
| <p class="lh-lg">This is a long paragraph written to show how the line-height of an element is affected by our utilities. Classes are applied to the element itself or sometimes the parent element. These classes can be customized as needed with our utility API.</p> | |||
| {{< /example >}} | |||
|
|
|||
| ## Line length | |||
|
|
|||
| Limit the line length with `.ll-*` utilities. It applies `max-width` rule to an element with a width based on `ch` dimension, only on block-level elements and not on inline elements. | |||
There was a problem hiding this comment.
max-width us a property, not a rule.
ch is a unit, not a dimension—and maybe explain why it's done using this unit?
No need to mention block/inline since max-width doesn't apply to inline elements anyway. Probably better to mention that it required anything but inline to apply.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #219 Netlify : https://deploy-preview-883--boosted.netlify.app/docs/5.1/utilities/text/#line-length
Adding a class instead of a boolean attribute because of the css optimization. Moreover, I think it fits well with text utilities section.