Layouts: add a top margin to the doc footer #934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MewenLeHo
reviewed
Nov 25, 2021
|
Good point yeah. Maybe me could remove this border. I think it's inherited from Bootstrap 4; Bootstrap 5 doesn't have this border anymore. |
Good idea, it will also look more modern 👍 |
julien-deramond
force-pushed
the
main-jd-missing-top-margin-doc-footer
branch
from
1f30e82
to
d3bb712
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a top margin to the doc footer to avoid this rendering when the side menu is non collapsed and we scroll:
New rendering:
