Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pa11y-ci from 2.42.0 to 3.0.1 #938

Merged
merged 27 commits into from Dec 7, 2022
Merged

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Nov 29, 2021

With this new version of pa11y-ci, the axe-core version has been bumped from 3.5.6 to 4.3.5 as well.
It means that there are new errors (more than 400 😱) tracked by aXe (via pa11y) on Boosted.

It is needed to:

  • analyze all the new errors
  • fix them if needed or hide them from the pa11y analysis in the hiddenElements configuration

Deployed version of Boosted: https://deploy-preview-938--boosted.netlify.app/
Pa11y HTML report:

Example with the first new error

URL: http://localhost:9001/docs/5.1/getting-started/accessibility/

• Elements must have sufficient color contrast (https://dequeuniversity.com/rules/axe/4.3/color-contrast?application=axeAPI)

(html > body > div:nth-child(6) > main > div:nth-child(3) > p:nth-child(3) > a:nth-child(1))

<abbr title="Web Content Access...

✘ 0/1 URLs passed

It is confirmed by the Firefox browser extension:

Screenshot from 2021-12-23 09-14-52

Reviewers

Checkout this main-jd-bump-pa11y-ci branch.
Run npm i.
Run npm run start in one console.
Run npm run docs-pa11y in another console once the start is done.

@julien-deramond julien-deramond marked this pull request as draft November 29, 2021 08:05
@julien-deramond julien-deramond self-assigned this Nov 29, 2021
@julien-deramond julien-deramond added dependencies Pull requests that update a dependency file v5 labels Nov 29, 2021
@julien-deramond julien-deramond force-pushed the main-jd-bump-pa11y-ci branch 2 times, most recently from 26eb3e7 to f737a30 Compare December 15, 2021 13:08
@julien-deramond julien-deramond changed the title Bump pa11y-ci from 2.42.0 to 3.0.0 Bump pa11y-ci from 2.42.0 to 3.0.1 Dec 23, 2021
@julien-deramond
Copy link
Member Author

julien-deramond commented Dec 28, 2021

⚠️ Executing axe DevTools Firefox extension on Ubuntu and macOS gives different results. For example, the 1st error mentioned in the description doesn't appear in the results under macOS...
axe DevTools Firefox extension on Ubuntu seems closer to the pa11y-ci results; seems logical because the GitHub workflows are executed in an Ubuntu env.

The same behavior than macOS is observed with Windows at Orange (less results than with Ubuntu).

@netlify
Copy link

netlify bot commented Nov 28, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 3f2b8a0
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/63908700a49d8b00090bc02b
😎 Deploy Preview https://deploy-preview-938--boosted.netlify.app/docs/5.2/migration
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@julien-deramond
Copy link
Member Author

julien-deramond commented Dec 6, 2022

For future selves. As a reminder.

Rendering of pa11y tests locally when everything's OK

Screenshot 2022-12-06 at 12 37 43

Rendering of pa11y tests locally with errors

(for example if we remove a rule that hides some use cases)

While running

Screenshot 2022-12-06 at 12 41 12

At the end

Screenshot 2022-12-06 at 12 41 41

Rendering of pa11y-ci tests via GitHub actions with errors

While running

Screenshot 2022-12-06 at 12 45 48

At the end

Screenshot 2022-12-06 at 12 50 33

Screenshot 2022-12-06 at 12 50 09

And in "Summary"

Screenshot 2022-12-06 at 12 51 02

Copy link
Contributor

@Aniort Aniort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok on my side

@julien-deramond julien-deramond added this to In progress in 🟣 Sprint 16 - December 2022 via automation Dec 7, 2022
@julien-deramond julien-deramond added this to In progress in v5.2.3 Dec 7, 2022
@julien-deramond julien-deramond moved this from In progress to In review in 🟣 Sprint 16 - December 2022 Dec 7, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julien-deramond
Copy link
Member Author

Good job @louismaximepiton 💪
Haven't checked the a11y content in details since already done by Vincent.
LGTM! Mergin' it! 🚀
Please modify https://github.com/Orange-OpenSource/Orange-Boosted-Bootstrap/wiki/Docs-accessibility-issues with the new rules and explanations. And then rebase #1677. You can also create PRs for Bootstrap if not already done.

@julien-deramond julien-deramond merged commit f5ed0b7 into main Dec 7, 2022
v5.2.3 automation moved this from In progress to Done Dec 7, 2022
@julien-deramond julien-deramond deleted the main-jd-bump-pa11y-ci branch December 7, 2022 12:42
🟣 Sprint 16 - December 2022 automation moved this from In review to Done Dec 7, 2022
@julien-deramond julien-deramond mentioned this pull request Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants