Skip to content
This repository has been archived by the owner on Oct 20, 2022. It is now read-only.

Resolved issue relating to basepath containing '/' #58

Merged
merged 3 commits into from
Nov 30, 2016
Merged

Resolved issue relating to basepath containing '/' #58

merged 3 commits into from
Nov 30, 2016

Conversation

daniel-cotton
Copy link
Contributor

Issue number: #46

Resolved issue relating to basepath containing '/' and leading to duplication of forward slashes (/) in try-me URL.

@daniel-cotton
Copy link
Contributor Author

Improved fix - any trailing slashes are removed if applicable.

@mathieuales
Copy link
Collaborator

mathieuales commented Nov 30, 2016

Hi !

Thanks for sharing !
Could you please make it a little bit more compact ?
swagger.basePath.substring(swagger.basePath.length - 1) === '/' ? swagger.basePath.slice(0, -1) : swagger.basePath
Your fix does not take into account that basePath can be null or empty as it was done before ...

Regards

@daniel-cotton
Copy link
Contributor Author

Hi @mathieuales,

Thanks for the feedback! I've incorporated your changes & added a quick null/undefined check.

Thanks,
Dan

@mathieuales mathieuales merged commit 6882c8b into Orange-OpenSource:master Nov 30, 2016
mathieuales added a commit that referenced this pull request Nov 30, 2016
@daniel-cotton daniel-cotton mentioned this pull request Nov 30, 2016
@anil-kk
Copy link
Contributor

anil-kk commented Dec 6, 2016

It looks like the problem is partially solved, I pulled a new request, When will be a new version released ? I still have older versions when I get the packages using Bower

@mathieuales
Copy link
Collaborator

Hi !
I'm working on other stuffs, a new release including the fix will come soon

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants