Refacto error_string in order to support diff messages

Orange-OpenSource · Apr 2, 2024 · cb41092 · cb41092
1 parent 0aef995
commit cb41092
Show file tree

Hide file tree

Showing 6 changed files with 237 additions and 96 deletions.
diff --git a/integration/hurl/tests_failed/assert_newline.err b/integration/hurl/tests_failed/assert_newline.err
@@ -5,7 +5,7 @@ error: Assert body value
    | ...
 10 | <p>Hello</p>
    | ^ actual value is <<p>Hello</p>
-
->
+   |
+   |   >
    |
 
diff --git a/packages/hurl/src/runner/error.rs b/packages/hurl/src/runner/error.rs
@@ -179,7 +179,7 @@ impl hurl_core::error::Error for Error {
                 } else {
                     ""
                 };
-                format!("actual:   {actual}\nexpected: {expected}{additional}")
+                format!("   actual:   {actual}\n   expected: {expected}{additional}")
             }
             RunnerError::AssertHeaderValueError { actual } => {
                 format!("actual value is <{actual}>")
@@ -257,6 +257,14 @@ impl hurl_core::error::Error for Error {
             }
         }
     }
+
+    fn show_source_line(&self) -> bool {
+        true
+    }
+
+    fn show_caret(&self) -> bool {
+        !matches!(&self.inner, RunnerError::AssertFailure { .. })
+    }
 }
 
 impl From<HttpError> for RunnerError {