Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement --max-filesize curl option #2353

Closed
jcamiel opened this issue Jan 24, 2024 · 4 comments
Closed

Implement --max-filesize curl option #2353

jcamiel opened this issue Jan 24, 2024 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers topic: curl options
Milestone

Comments

@jcamiel
Copy link
Collaborator

jcamiel commented Jan 24, 2024

With --output user can download response to file system. Implementing --max-filesize can help preventing download of too big files.

@jcamiel jcamiel added the enhancement New feature or request label Jan 24, 2024
@jcamiel jcamiel added this to the 4.3.0 milestone Jan 24, 2024
@jcamiel jcamiel added the good first issue Good for newcomers label Feb 15, 2024
@Orange-OpenSource Orange-OpenSource deleted a comment from baerwang Feb 29, 2024
@baerwang
Copy link
Contributor

when will you review my code?

@fabricereix
Copy link
Collaborator

you need to sign your commits
image

@fabricereix
Copy link
Collaborator

if the max filesize is reached, Hurl should probably exit in error to be consistent with curl.

$ curl --max-filesize 10 https://hurl.dev
curl: (63) Maximum file size exceeded
$ echo $?
63

@jcamiel jcamiel linked a pull request Apr 1, 2024 that will close this issue
@jcamiel
Copy link
Collaborator Author

jcamiel commented Apr 1, 2024

Fixed by #2468

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers topic: curl options
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants