Add --max-filesize option to limit HTTP response

[baerwang]

#2353

develop process

options

cargo clippy

tests_ok/help.sh

[jcamiel]

The option max_filesize should also work for [Options]section:

GET https://foo.com
output: bar.bin
max-filesize: 128000
HTTP 200

[jcamiel]

Hi @baerwang

To make the CI OK, you should look at the integration test tests_ok/help.sh: this is a simple test that checks the output of hurl --help. When adding a new option, we must update this test.

[jcamiel]

EnryResult struct doesn't need to change. max_filesize must be passed to run method (with RunnerOptions) so we can configure libcurl to use it. This way we don't have to check the dfile size when we write a response: the exchange will be in error if the file size is greater than the optiions.

[jcamiel]

Ho @baerwang I can help with this PR and push some fixes if you want!

[baerwang]

Ho @baerwang I can help with this PR and push some fixes if you want!

i'll changed this code at sunday

[jcamiel]

We should use an Option<usize> instead of a usize for max_filesize fields.

[jcamiel]

Hi @baerwang if it's ok with you, I'm doing some minor changes on your branch to finish it

[jcamiel]

/accept --force

[hurl-bot]

🕗 /accept --force is running, please wait for completion.

[hurl-bot]

✅ Pull request merged without waiting for checks and closed by jcamiel with fast forward merge..

# List of commits merged from baerwang/hurl/feat/file-limit branch into Orange-OpenSource/hurl/master branch:

• 7787d71 feat: File size limits

[jcamiel]

Thanks @baerwang for this PR